Skip to content

Commit 3ea7201

Browse files
gselzerctrueden
authored andcommitted
Remove javadoc about hints construction
None of the stuff it describes is needed anymore. Note that it is now possible for both Simplification.IN_PROGRESS and Simplification.FORBIDDEN to exist in the same Hints object. This should be fine
1 parent fa2ffef commit 3ea7201

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

scijava/scijava-ops-engine/src/main/java/org/scijava/ops/engine/simplify/SimplifiedOpRef.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,23 +109,15 @@ public static SimplifiedOpRef simplificationOf(OpEnvironment env, OpRef ref,
109109
* Adaptation is similarly forbidden, as to convert most Op types to
110110
* {@link Arity1} you would need an identical copy Op.
111111
* <p>
112-
* NB We create the {@link Hints} using the construction
113-
* {@code new DefaultHints(hints.getHints())} instead of using the
114-
* construction {@code hints.copy(true)} because we <b>do not</b> want to
115-
* ensure that we are not passing a {@code SimplificationHints} to the
116-
* matcher. We need to forbid simplification to prevent an infinite loop, but
117-
* the Simplification hint type is restricted to
118-
* {@code Simplification.IN_PROGRESS} by the {@code SimplificationHints}. This
119-
* is likely a bug, but would be best fixed by sliming down the {@link Hints}
120-
* implementations.
121-
*
112+
*
122113
* @param copyType - the {@link Type} that we need to be able to copy
123114
* @param hints
124115
* @return an {@code Op} able to copy data between {@link Object}s of
125116
* {@link Type} {@code copyType}
126117
* @throws OpMatchingException
127118
*/
128119
private static InfoChain simplifierCopyOp(OpEnvironment env, Type copyType, Hints hints) throws OpMatchingException{
120+
// prevent further simplification/adaptation
129121
Hints hintsCopy = hints.copy() //
130122
.plus(Adaptation.FORBIDDEN, Simplification.FORBIDDEN);
131123

0 commit comments

Comments
 (0)