Reject Op not declaring a name during op discovery

Treiblesschorle · gselzer · commit 30324ab8bb13 · 2019-04-12T12:54:02.000-05:00
diff --git a/src/main/java/org/scijava/ops/OpService.java b/src/main/java/org/scijava/ops/OpService.java
@@ -125,14 +125,19 @@ public void initOpCache() {
 	}
 	
 	private void addToCache(OpInfo opInfo, String opNames) {
+		String[] parsedOpNames = OpUtils.parseOpNames(opNames);
+		if (parsedOpNames == null || parsedOpNames.length == 0) {
+			log.error("Skipping Op " + opInfo.implementationName() + ":\n"
+					+ "Op implementation must provide name.");
+			return;
+		}
 		if (!opInfo.isValid()) {
 			log.error("Skipping invalid Op " + opInfo.implementationName() + ":\n"
 					+ opInfo.getValidityException().getMessage());
 			return;
 		}
-		String[] parsedNames = OpUtils.parseOpNames(opNames);
-		addAliases(parsedNames, opInfo.implementationName());
-		opCache.add(new PrefixQuery(parsedNames[0]), opInfo);
+		addAliases(parsedOpNames, opInfo.implementationName());
+		opCache.add(new PrefixQuery(parsedOpNames[0]), opInfo);
 	}
 
 	@Override
diff --git a/src/main/java/org/scijava/ops/OpUtils.java b/src/main/java/org/scijava/ops/OpUtils.java
@@ -108,8 +108,15 @@ public static String[] parseOpNames(String names) {
 	 * @return
 	 */
 	public static String[] parseOpName(String name) {
-		String[] split = name.split("\\.");
-		return new String[] { name, split[split.length - 1] };
+		if (name == null || name.isEmpty()) {
+			return new String[]{};
+		}
+		if (name.contains(".")) {
+			String[] split = name.split("\\.");
+			return new String[] { name, split[split.length - 1] };
+		} else {
+			return new String[]{name};
+		}
 	}
 
 	public static List<MemberInstance<?>> inputs(StructInstance<?> op) {
