CI: avoid using subshell for cache mod detection

ctrueden · ctrueden · commit f32753e1f868 · 2023-03-10T15:31:37.000-06:00
It's already called in a subshell due to $(last_cache_modified).
Nested subshells should be fine, but in practice the CI builds are
complaining with a weird error:

  sort: write failed: 'standard output': Broken pipe
  sort: write error

Let's see if this change makes any difference!
diff --git a/.github/build.sh b/.github/build.sh
@@ -4,9 +4,7 @@ sh ci-build.sh || { echo "Maven build failed. Skipping melting pot tests."; exit
 
 # Helper method to get the last cache modified date as seconds since epoch
 last_cache_modified () {
-  cache_modified=$(find ~/.cache/scijava/melting-pot -printf '%T@\n' | sort -r | head -n1)
-  cache_modified=${cache_modified%.*}
-  echo "$cache_modified"
+  find ~/.cache/scijava/melting-pot -printf '%T@\n' | sort -r | head -n1 | sed 's/\..*$//'
 }
 
 # Record the last time of cache modification before running melting-pot

Original file line number	Diff line number	Diff line change
`@@ -4,9 +4,7 @@ sh ci-build.sh \|\| { echo "Maven build failed. Skipping melting pot tests."; exit`
`4`	`4`
`5`	`5`	`# Helper method to get the last cache modified date as seconds since epoch`
`6`	`6`	`last_cache_modified () {`
`7`		`- cache_modified=$(find ~/.cache/scijava/melting-pot -printf '%T@\n' \| sort -r \| head -n1)`
`8`		`- cache_modified=${cache_modified%.*}`
`9`		`- echo "$cache_modified"`
	`7`	`+ find ~/.cache/scijava/melting-pot -printf '%T@\n' \| sort -r \| head -n1 \| sed 's/\..*$//'`
`10`	`8`	`}`
`11`	`9`
`12`	`10`	`# Record the last time of cache modification before running melting-pot`