-
Notifications
You must be signed in to change notification settings - Fork 11
Expand file tree
/
Copy pathtest_deduplication.py
More file actions
386 lines (300 loc) · 15.5 KB
/
test_deduplication.py
File metadata and controls
386 lines (300 loc) · 15.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
import pytest
from nucleus import Dataset, DatasetItem, NucleusClient, VideoScene
from nucleus.deduplication import DeduplicationResult
from nucleus.errors import NucleusAPIError
from .helpers import (
DEDUP_DEFAULT_TEST_THRESHOLD,
TEST_DATASET_ITEMS,
TEST_DATASET_NAME,
TEST_IMG_URLS,
TEST_VIDEO_DATASET_NAME,
TEST_VIDEO_SCENES,
TEST_VIDEO_URL,
)
def test_deduplicate_empty_reference_ids_raises_error():
fake_dataset = Dataset("fake", NucleusClient("fake"))
with pytest.raises(ValueError, match="reference_ids cannot be empty"):
fake_dataset.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD, reference_ids=[])
def test_deduplicate_by_ids_empty_list_raises_error():
fake_dataset = Dataset("fake", NucleusClient("fake"))
with pytest.raises(ValueError, match="dataset_item_ids must be non-empty"):
fake_dataset.deduplicate_by_ids(threshold=DEDUP_DEFAULT_TEST_THRESHOLD, dataset_item_ids=[])
@pytest.fixture(scope="module")
def dataset_image_sync(CLIENT):
"""Image dataset uploaded synchronously."""
ds = CLIENT.create_dataset(TEST_DATASET_NAME + " dedup sync", is_scene=False)
try:
ds.append(TEST_DATASET_ITEMS)
yield ds
finally:
CLIENT.delete_dataset(ds.id)
@pytest.fixture(scope="module")
def dataset_image_async(CLIENT):
"""Image dataset uploaded asynchronously."""
ds = CLIENT.create_dataset(TEST_DATASET_NAME + " dedup async", is_scene=False)
try:
job = ds.append(TEST_DATASET_ITEMS, asynchronous=True)
job.sleep_until_complete()
yield ds
finally:
CLIENT.delete_dataset(ds.id)
@pytest.mark.integration
def test_deduplicate_image_sync_entire_dataset(dataset_image_sync):
"""Test deduplication on image dataset uploaded synchronously."""
result = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
assert isinstance(result, DeduplicationResult)
assert len(result.unique_reference_ids) > 0
assert len(result.unique_item_ids) > 0
assert result.stats.original_count == len(TEST_DATASET_ITEMS)
@pytest.mark.integration
def test_deduplicate_image_sync_with_reference_ids(dataset_image_sync):
"""Test deduplication with reference IDs on image dataset uploaded synchronously."""
reference_ids = [item.reference_id for item in TEST_DATASET_ITEMS[:2]]
result = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD, reference_ids=reference_ids)
assert isinstance(result, DeduplicationResult)
assert result.stats.original_count == len(reference_ids)
assert len(result.unique_reference_ids) <= len(reference_ids)
assert len(result.unique_item_ids) <= len(reference_ids)
@pytest.mark.integration
def test_deduplicate_image_sync_by_ids(dataset_image_sync):
"""Test deduplicate_by_ids on image dataset uploaded synchronously."""
initial_result = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
item_ids = initial_result.unique_item_ids
assert len(item_ids) > 0
result = dataset_image_sync.deduplicate_by_ids(threshold=DEDUP_DEFAULT_TEST_THRESHOLD, dataset_item_ids=item_ids)
assert isinstance(result, DeduplicationResult)
assert result.stats.original_count == len(item_ids)
assert result.unique_item_ids == initial_result.unique_item_ids
@pytest.mark.integration
def test_deduplicate_image_async_entire_dataset(dataset_image_async):
"""Test deduplication on image dataset uploaded asynchronously."""
result = dataset_image_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
assert isinstance(result, DeduplicationResult)
assert len(result.unique_reference_ids) > 0
assert len(result.unique_item_ids) > 0
assert result.stats.original_count == len(TEST_DATASET_ITEMS)
@pytest.mark.integration
def test_deduplicate_image_async_with_reference_ids(dataset_image_async):
"""Test deduplication with reference IDs on image dataset uploaded asynchronously."""
reference_ids = [item.reference_id for item in TEST_DATASET_ITEMS[:2]]
result = dataset_image_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD, reference_ids=reference_ids)
assert isinstance(result, DeduplicationResult)
assert result.stats.original_count == len(reference_ids)
assert len(result.unique_reference_ids) <= len(reference_ids)
assert len(result.unique_item_ids) <= len(reference_ids)
@pytest.mark.integration
def test_deduplicate_image_async_by_ids(dataset_image_async):
"""Test deduplicate_by_ids on image dataset uploaded asynchronously."""
initial_result = dataset_image_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
item_ids = initial_result.unique_item_ids
assert len(item_ids) > 0
result = dataset_image_async.deduplicate_by_ids(threshold=DEDUP_DEFAULT_TEST_THRESHOLD, dataset_item_ids=item_ids)
assert isinstance(result, DeduplicationResult)
assert result.stats.original_count == len(item_ids)
assert result.unique_item_ids == initial_result.unique_item_ids
@pytest.fixture(scope="module")
def dataset_video_scene_async(CLIENT):
"""Video scene dataset (with frames) uploaded asynchronously."""
ds = CLIENT.create_dataset(TEST_VIDEO_DATASET_NAME + " dedup async", is_scene=True)
try:
scene_1 = TEST_VIDEO_SCENES["scenes"][0]
scenes = [VideoScene.from_json(scene_1)]
job = ds.append(scenes, asynchronous=True)
job.sleep_until_complete()
yield ds
finally:
CLIENT.delete_dataset(ds.id)
def _get_scene_frame_ref_ids():
"""Extract frame reference IDs from TEST_VIDEO_SCENES scene_1."""
return [frame["reference_id"] for frame in TEST_VIDEO_SCENES["scenes"][0]["frames"]]
@pytest.mark.integration
def test_deduplicate_video_scene_async_entire_dataset(dataset_video_scene_async):
"""Test deduplication on video scene dataset uploaded asynchronously."""
result = dataset_video_scene_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
assert isinstance(result, DeduplicationResult)
assert len(result.unique_reference_ids) > 0
assert len(result.unique_item_ids) > 0
assert result.stats.original_count == len(_get_scene_frame_ref_ids())
@pytest.mark.integration
def test_deduplicate_video_scene_async_with_frame_reference_ids(dataset_video_scene_async):
"""Test deduplication with frame reference IDs on video scene dataset uploaded asynchronously."""
frame_ref_ids = _get_scene_frame_ref_ids()
result = dataset_video_scene_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD, reference_ids=frame_ref_ids)
assert isinstance(result, DeduplicationResult)
assert result.stats.original_count == len(frame_ref_ids)
assert len(result.unique_reference_ids) <= len(frame_ref_ids)
assert len(result.unique_item_ids) <= len(frame_ref_ids)
@pytest.mark.integration
def test_deduplicate_video_scene_async_by_ids(dataset_video_scene_async):
"""Test deduplicate_by_ids on video scene dataset uploaded asynchronously."""
initial_result = dataset_video_scene_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
item_ids = initial_result.unique_item_ids
assert len(item_ids) > 0
result = dataset_video_scene_async.deduplicate_by_ids(
threshold=DEDUP_DEFAULT_TEST_THRESHOLD, dataset_item_ids=item_ids
)
assert isinstance(result, DeduplicationResult)
assert result.stats.original_count == len(item_ids)
assert result.unique_item_ids == initial_result.unique_item_ids
@pytest.fixture(scope="module")
def dataset_video_url_async(CLIENT):
"""Video URL dataset uploaded asynchronously."""
ds = CLIENT.create_dataset(TEST_VIDEO_DATASET_NAME + " video_url dedup async", is_scene=True)
try:
scene = VideoScene.from_json({
"reference_id": "video_url_scene_async",
"video_url": TEST_VIDEO_URL,
"metadata": {"test": "video_url_dedup_async"},
})
job = ds.append([scene], asynchronous=True)
job.sleep_until_complete()
yield ds
finally:
CLIENT.delete_dataset(ds.id)
@pytest.mark.integration
def test_deduplicate_video_url_async_entire_dataset(dataset_video_url_async):
"""Test deduplication on video URL dataset uploaded asynchronously."""
result = dataset_video_url_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
assert isinstance(result, DeduplicationResult)
assert len(result.unique_reference_ids) > 0
assert len(result.unique_item_ids) > 0
assert result.stats.original_count > 0
@pytest.mark.integration
def test_deduplicate_video_url_async_by_ids(dataset_video_url_async):
"""Test deduplicate_by_ids on video URL dataset uploaded asynchronously."""
initial_result = dataset_video_url_async.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
item_ids = initial_result.unique_item_ids
assert len(item_ids) > 0
result = dataset_video_url_async.deduplicate_by_ids(
threshold=DEDUP_DEFAULT_TEST_THRESHOLD, dataset_item_ids=item_ids
)
assert isinstance(result, DeduplicationResult)
assert result.stats.original_count == len(item_ids)
assert result.unique_item_ids == initial_result.unique_item_ids
# Edge case tests
@pytest.mark.integration
def test_deduplicate_threshold_zero(dataset_image_sync):
"""Verify threshold=0 (exact match only) succeeds and returns correct stats."""
result = dataset_image_sync.deduplicate(threshold=0)
assert isinstance(result, DeduplicationResult)
assert result.stats.threshold == 0
@pytest.mark.integration
def test_deduplicate_threshold_max(dataset_image_sync):
"""Verify threshold=64 (maximum allowed) succeeds and returns correct stats."""
result = dataset_image_sync.deduplicate(threshold=64)
assert isinstance(result, DeduplicationResult)
assert result.stats.threshold == 64
@pytest.mark.integration
def test_deduplicate_threshold_negative(dataset_image_sync):
"""Verify negative threshold raises NucleusAPIError (must be >= 0)."""
with pytest.raises(NucleusAPIError):
dataset_image_sync.deduplicate(threshold=-1)
@pytest.mark.integration
def test_deduplicate_threshold_too_high(dataset_image_sync):
"""Verify threshold > 64 raises NucleusAPIError (must be <= 64)."""
with pytest.raises(NucleusAPIError):
dataset_image_sync.deduplicate(threshold=65)
@pytest.mark.integration
def test_deduplicate_threshold_non_integer(dataset_image_sync):
"""Verify non-integer threshold raises NucleusAPIError."""
with pytest.raises(NucleusAPIError):
dataset_image_sync.deduplicate(threshold=10.5)
@pytest.mark.integration
def test_deduplicate_nonexistent_reference_id(dataset_image_sync):
"""Verify nonexistent reference_id raises NucleusAPIError."""
with pytest.raises(NucleusAPIError):
dataset_image_sync.deduplicate(
threshold=DEDUP_DEFAULT_TEST_THRESHOLD, reference_ids=["nonexistent_ref_id"]
)
@pytest.mark.integration
def test_deduplicate_by_ids_nonexistent_id(dataset_image_sync):
"""Verify nonexistent dataset_item_id raises NucleusAPIError."""
with pytest.raises(NucleusAPIError):
dataset_image_sync.deduplicate_by_ids(
threshold=DEDUP_DEFAULT_TEST_THRESHOLD, dataset_item_ids=["di_nonexistent"]
)
@pytest.mark.integration
def test_deduplicate_idempotency(dataset_image_sync):
"""Verify repeated deduplication calls return consistent results."""
result1 = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
result2 = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
assert result1.unique_item_ids == result2.unique_item_ids
assert result1.unique_reference_ids == result2.unique_reference_ids
assert result1.stats.original_count == result2.stats.original_count
assert result1.stats.deduplicated_count == result2.stats.deduplicated_count
@pytest.mark.integration
def test_deduplicate_response_invariants(dataset_image_sync):
"""Verify response maintains expected invariants between fields."""
result = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
assert len(result.unique_item_ids) == len(result.unique_reference_ids)
assert result.stats.deduplicated_count == len(result.unique_item_ids)
assert result.stats.deduplicated_count <= result.stats.original_count
assert result.stats.threshold == DEDUP_DEFAULT_TEST_THRESHOLD
@pytest.mark.integration
def test_deduplicate_by_ids_threshold_negative(dataset_image_sync):
"""Verify deduplicate_by_ids rejects negative threshold."""
initial_result = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
item_ids = initial_result.unique_item_ids
with pytest.raises(NucleusAPIError):
dataset_image_sync.deduplicate_by_ids(threshold=-1, dataset_item_ids=item_ids)
@pytest.mark.integration
def test_deduplicate_by_ids_threshold_too_high(dataset_image_sync):
"""Verify deduplicate_by_ids rejects threshold > 64."""
initial_result = dataset_image_sync.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
item_ids = initial_result.unique_item_ids
with pytest.raises(NucleusAPIError):
dataset_image_sync.deduplicate_by_ids(threshold=65, dataset_item_ids=item_ids)
@pytest.mark.integration
def test_deduplicate_single_item(dataset_image_sync):
"""Verify single item deduplication returns that item as unique."""
reference_ids = [TEST_DATASET_ITEMS[0].reference_id]
result = dataset_image_sync.deduplicate(
threshold=DEDUP_DEFAULT_TEST_THRESHOLD, reference_ids=reference_ids
)
assert result.stats.original_count == 1
assert result.stats.deduplicated_count == 1
assert len(result.unique_reference_ids) == 1
@pytest.fixture(scope="function")
def dataset_empty(CLIENT):
"""Empty dataset with no items."""
ds = CLIENT.create_dataset(TEST_DATASET_NAME + " empty", is_scene=False)
try:
yield ds
finally:
CLIENT.delete_dataset(ds.id)
@pytest.mark.integration
def test_deduplicate_empty_dataset(dataset_empty):
"""Verify deduplication on empty dataset returns zero counts."""
result = dataset_empty.deduplicate(threshold=DEDUP_DEFAULT_TEST_THRESHOLD)
assert result.stats.original_count == 0
assert result.stats.deduplicated_count == 0
assert len(result.unique_reference_ids) == 0
assert len(result.unique_item_ids) == 0
@pytest.fixture(scope="function")
def dataset_with_duplicates(CLIENT):
"""Dataset with duplicate images (same image uploaded twice)."""
ds = CLIENT.create_dataset(TEST_DATASET_NAME + " duplicates", is_scene=False)
try:
items = [
DatasetItem(TEST_IMG_URLS[0], reference_id="img_original"),
DatasetItem(TEST_IMG_URLS[0], reference_id="img_duplicate"),
DatasetItem(TEST_IMG_URLS[1], reference_id="img_different"),
]
ds.append(items)
yield ds
finally:
CLIENT.delete_dataset(ds.id)
@pytest.mark.integration
def test_deduplicate_identifies_duplicates(dataset_with_duplicates):
"""Verify deduplication actually identifies duplicate images."""
result = dataset_with_duplicates.deduplicate(threshold=0)
assert result.stats.original_count == 3
# With threshold=0, the two identical images should be deduplicated to one
assert result.stats.deduplicated_count == 2
assert len(result.unique_reference_ids) == 2
@pytest.mark.integration
def test_deduplicate_distinct_images_all_unique(dataset_image_sync):
"""Distinct images should all remain after deduplication."""
result = dataset_image_sync.deduplicate(threshold=0)
# With threshold=0 (exact match only), all distinct images should be unique
assert result.stats.deduplicated_count == result.stats.original_count