rename formatMethodSig

aymanelamyaghri · aymanelamyaghri · commit 5c4ff53a69a7 · 2023-05-11T14:32:42.000+02:00
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/IStepFilterProvider.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/IStepFilterProvider.java
@@ -19,7 +19,7 @@
 public interface IStepFilterProvider extends IProvider {
     boolean shouldSkipOver(Method method, Requests.StepFilters filters);
     boolean shouldSkipFrame(Method method);
-    Optional<String> formatMethodName(Method method );
+    Optional<String> formatMethodSig(Method method );
 
     boolean shouldSkipOut(Location upperLocation, Method method);
 }
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/StepFilterProvider.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/StepFilterProvider.java
@@ -51,7 +51,7 @@ public boolean shouldSkipFrame(Method method) {
 
 
     @Override
-    public Optional<String> formatMethodName(Method method) {
+    public Optional<String> formatMethodSig(Method method) {
         return Optional.of(method.name());
     }
 
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java
@@ -79,7 +79,7 @@ public CompletableFuture<Response> handle(Command command, Arguments arguments,
                     StackFrameReference stackframe = new StackFrameReference(thread, i);
                     int frameId = context.getRecyclableIdPool().addObject(thread.uniqueID(), stackframe);
                    IStepFilterProvider stackTraceFilterProvider = context.getProvider(IStepFilterProvider.class);
-                   Optional<String> optionalFormattedName = stackTraceFilterProvider.formatMethodName(thread.frame(i).location().method());
+                   Optional<String> optionalFormattedName = stackTraceFilterProvider.formatMethodSig(thread.frame(i).location().method());
             
                    
                  if(!stackTraceFilterProvider.shouldSkipFrame(thread.frame(i).location().method())  && !optionalFormattedName.isEmpty() )

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`public interface IStepFilterProvider extends IProvider {`
`20`	`20`	`boolean shouldSkipOver(Method method, Requests.StepFilters filters);`
`21`	`21`	`boolean shouldSkipFrame(Method method);`
`22`		`- Optional<String> formatMethodName(Method method );`
	`22`	`+ Optional<String> formatMethodSig(Method method );`
`23`	`23`
`24`	`24`	`boolean shouldSkipOut(Location upperLocation, Method method);`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public boolean shouldSkipFrame(Method method) {`
`51`	`51`
`52`	`52`
`53`	`53`	`@Override`
`54`		`- public Optional<String> formatMethodName(Method method) {`
	`54`	`+ public Optional<String> formatMethodSig(Method method) {`
`55`	`55`	`return Optional.of(method.name());`
`56`	`56`	`}`
`57`	`57`