Fix PSReadLine history path on Windows

andyleejordan · andyleejordan · commit 140d452ba2bf · 2016-06-09T09:50:36.000-07:00
Bug introduced in initial port of PSReadLine. `Path.Combine` sees the
initial backslash as an absolute path, thus discarding `AppData`.
diff --git a/src/Microsoft.PowerShell.PSReadLine/Cmdlets.cs b/src/Microsoft.PowerShell.PSReadLine/Cmdlets.cs
@@ -172,8 +172,8 @@ public PSConsoleReadlineOptions(string hostName)
 #if CORECLR
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))   // MS Windows
             {
-                HistorySavePath = System.IO.Path.Combine(Environment.ExpandEnvironmentVariables("%AppData%"),
-                                                         @"\Microsoft\Windows\PowerShell\PSReadline\",
+                HistorySavePath = System.IO.Path.Combine(Environment.GetEnvironmentVariable("APPDATA"),
+                                                         @"Microsoft\Windows\PowerShell\PSReadline\",
                                                          hostName + "_history.txt");
             }
 

Original file line number	Diff line number	Diff line change
`@@ -172,8 +172,8 @@ public PSConsoleReadlineOptions(string hostName)`
`172`	`172`	`#if CORECLR`
`173`	`173`	`if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) // MS Windows`
`174`	`174`	`{`
`175`		`- HistorySavePath = System.IO.Path.Combine(Environment.ExpandEnvironmentVariables("%AppData%"),`
`176`		`- @"\Microsoft\Windows\PowerShell\PSReadline\",`
	`175`	`+ HistorySavePath = System.IO.Path.Combine(Environment.GetEnvironmentVariable("APPDATA"),`
	`176`	`+ @"Microsoft\Windows\PowerShell\PSReadline\",`
`177`	`177`	`hostName + "_history.txt");`
`178`	`178`	`}`
`179`	`179`