Automatic commit: Move 'iot-smartsensing-qcgr-destinations', 'iot-smartsensing-quality-control-rules-actions', 'iot-smartsensing-s4destinations' from QA to Production

marco-porru · marco-porru · commit e0427e8ff935 · 2022-03-16T13:29:01.000+01:00
diff --git a/tutorials/iot-smartsensing-qcgr-destinations/iot-smartsensing-qcgr-destinations.md b/tutorials/iot-smartsensing-qcgr-destinations/iot-smartsensing-qcgr-destinations.md
@@ -39,8 +39,7 @@ Create a Destination which will allow you to create a Goods Receipt. You will in
     |  Name           | **`E5Z_PostGoodsReceipt_SAP_COM_0106`**  | of your choice, will be used in SAP IoT Action |
     |  Type           | `HTTP` |  |
     |  Description    |  | of your choice |
-    |  URL            | **`https://my300000.s4hana.ondemand.com/sap/opu/odata/sap/API_INBOUND_DELIVERY_SRV;
-    v=0002/PostGoodsReceipt?DeliveryDocument='^{lastValue(${thresholdCheck.deliveryDocument})}'`** | URL to the Goods Receipt API incl. placeholder tokens of your SAP S/4HANA Cloud system or Virtual Host for SAP S/4HANA |
+    |  URL            | **`https://my300000.s4hana.ondemand.com/sap/opu/odata/sap/API_INBOUND_DELIVERY_SRV;v=0002/PostGoodsReceipt?DeliveryDocument='^{lastValue(${thresholdCheck.deliveryDocument})}'`** | URL to the Goods Receipt API incl. placeholder tokens of your SAP S/4HANA Cloud system or Virtual Host for SAP S/4HANA |
     |  Proxy Type     | `Internet` or `OnPremise`| depending on Cloud or On-premise system |
     |  Authentication | `BasicAuthentication`, `OAuth2ClientCredentials` ... | based on your setup in the Communication Arrangement or Cloud Connector |
 
@@ -51,9 +50,8 @@ Create a Destination which will allow you to create a Goods Receipt. You will in
 
     |  Property Name    | Value |     Remark
     |  :-------------   | :-------------    | :-------------
-    |  `sap.iot.etagURL`          | **`https://my300000.s4hana.ondemand.com/sap/opu/odata/sap/API_INBOUND_DELIVERY_SRV;
-    v=0002/PostGoodsReceipt?DeliveryDocument='^{lastValue(${thresholdCheck.deliveryDocument})}'`** | URL to the Goods Receipt APIs incl. placeholder tokens of your SAP S/4HANA Cloud system or Virtual Host for SAP S/4HANA |
-    |  `sap.iot.XcsrfURL`     | **`https://my300000.s4hana.ondemand.com/sap/opu/odata/sap/API_INBOUND_DELIVERY_SRV;v=0002/PostGoodsReceipt?DeliveryDocument='^{lastValue(${thresholdCheck.deliveryDocument})}'`**  | URL to the Goods Receipt APIs incl. placeholder tokens of your SAP S/4HANA Cloud system or Virtual Host for SAP S/4HANA |
+    |  `sap.iot.etagURL`          | **`https://my300000.s4hana.ondemand.com/sap/opu/odata/sap/API_INBOUND_DELIVERY_SRV;v=0002/A_InbDeliveryHeader('^{lastValue(${thresholdCheck.deliveryDocument})}')`** | URL to the Goods Receipt APIs incl. placeholder tokens of your SAP S/4HANA Cloud system or Virtual Host for SAP S/4HANA |
+    |  `sap.iot.XcsrfURL`     | **`https://my300000.s4hana.ondemand.com/sap/opu/odata/sap/API_INBOUND_DELIVERY_SRV;v=0002/A_InbDeliveryHeader('^{lastValue(${thresholdCheck.deliveryDocument})}')`**  | URL to the Goods Receipt APIs incl. placeholder tokens of your SAP S/4HANA Cloud system or Virtual Host for SAP S/4HANA |
 
     > The property `sap.iot.etagURL` retrieves and adds an `ETag` Token during Action execution. It is an identifier for a specific version of a resource and helps to prevent simultaneous updates of a resource from overwriting each other.
     >
diff --git a/tutorials/iot-smartsensing-quality-control-rules-actions/iot-smartsensing-quality-control-rules-actions.md b/tutorials/iot-smartsensing-quality-control-rules-actions/iot-smartsensing-quality-control-rules-actions.md
@@ -63,6 +63,11 @@ Now that you have a **Rule Project**, you can create a rule. In the **Rule Proje
 
     threshold:
     SAP_Stream_Derivation.BusinessTime
+
+    ELSE IF ISNULL( thresholdCheck.threshold )
+
+    threshold:
+    'Jan 1, 1970 1:00:00 AM'
     ```
 
 6.  Now you can **Save** and **Activate** the **Rule on Cloud**.
@@ -89,9 +94,11 @@ In the **Rule Projects** app navigate to the **Rules** tab and create a **Stream
 5.  Using the interactive editor create your rule condition. In this condition we are not providing any value to `IoT_Event_Name` that will be populated differently.
 
     ```Rule
-    IF  ISNULL( thresholdCheck.threshold ) AND ISNOTNULL( thresholdCheck.scanningTime )  
+    thresholdCheck.threshold > 'Jan 1, 1990 1:00:00 AM' AND ISNOTNULL( thresholdCheck.scanningTime )  
     ```
 
+    >In the rule we are checking the threshold date is valid (current BusinessTime) and higher from the intial value `'Jan 1, 1970 1:00:00 AM'`.
+
     Create another Rule:
 
 6.  Provide a unique name for the name and description (for example, **`QualityNotOk`**).
@@ -105,9 +112,11 @@ In the **Rule Projects** app navigate to the **Rules** tab and create a **Stream
 10. Using the interactive editor create your rule condition. In this condition we are not providing any value to `IoT_Event_Name` that will be populated differently.
 
     ```Rule
-    IF  ISNOTNULL( thresholdCheck.threshold ) AND ISNOTNULL( thresholdCheck.scanningTime )  
+    thresholdCheck.threshold < 'Jan 1, 1990 1:00:00 AM' AND ISNOTNULL( thresholdCheck.scanningTime )
     ```
 
+    >In the rule we are checking the threshold date is the intial value `'Jan 1, 1970 1:00:00 AM'`.
+
 11. Activate both the rules.
 
 [DONE]
diff --git a/tutorials/iot-smartsensing-s4destinations/iot-smartsensing-s4destinations.md b/tutorials/iot-smartsensing-s4destinations/iot-smartsensing-s4destinations.md
@@ -55,11 +55,6 @@ You destination should look similar to this one at the end:
 
 > Further information on Destinations and supported Authentication methods see [SAP Help Portal of Internet of Things](https://help.sap.com/viewer/fbf2583f7bcf47fcb5107bf4d358770e/latest/en-US/87ec372e20ea48ba9843fc60a4723895.html) and [SAP Help Portal of SAP BTP Connectivity](https://help.sap.com/viewer/cca91383641e40ffbe03bdc78f00f681/Cloud/en-US/42a0e6b966924f2e902090bdf435e1b2.html)
 
-[DONE]
-[ACCORDION-END]
-
-[ACCORDION-BEGIN [Step 2: ](Test yourself)]
-
 [VALIDATE_5]
 [ACCORDION-END]
 
