Skip to content

Commit ec0d41e

Browse files
authored
Apply suggestions from code review
1 parent 1127346 commit ec0d41e

5 files changed

Lines changed: 17 additions & 9 deletions

docs/database-engine/service-broker/conversation-groups.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ Service Broker manages the lifetime of the conversation group. You do not need t
4646

4747
- Service Broker receives the first message on a new conversation started by another service. In this case, Service Broker uses the name of the service and the broker instance identifier (if one is present) to do the following:
4848

49-
1. Locate the appropriate queue.
49+
1. Locate the appropriate queue.
5050

51-
2. Create a new conversation group and associate the conversation group with the queue.
51+
2. Create a new conversation group and associate the conversation group with the queue.
5252

53-
3. Create a new conversation handle and add the conversation handle to the new conversation group.
53+
3. Create a new conversation handle and add the conversation handle to the new conversation group.
5454

55-
4. Place the incoming message on the queue.
55+
4. Place the incoming message on the queue.
5656

5757
Service Broker adds the conversation group identifier to the metadata for the conversation that created the conversation group. Whenever Service Broker receives a message for any conversation associated with the conversation group, Service Broker adds the conversation group identifier to that message before entering the message in the queue.
5858

docs/database-engine/service-broker/how-to-activate-service-broker-networking-transact-sql.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,12 @@ ms.date: "03/30/2022"
1414

1515
[!INCLUDE [sql-asdbmi](../../includes/applies-to-version/sql-asdbmi.md)]
1616

17-
Service Broker does not send or receive messages over the network by default. To activate Service Broker networking in an instance, create an endpoint for Service Broker.> [!NOTE]
18-
> Creating a Service Broker endpoint causes SQL Server to accept TCP/IP connections on the port specified. Service Broker transport security allows you to require authorization for connections to the port. If the computer that runs SQL Server has a firewall enabled, the firewall configuration on that computer must allow both incoming connections for the port specified in the endpoint. For more information on Service Broker transport security, see [Service Broker Transport Security](service-broker-transport-security.md).### To activate Service Broker networking
17+
Service Broker does not send or receive messages over the network by default. To activate Service Broker networking in an instance, create an endpoint for Service Broker.
18+
19+
> [!NOTE]
20+
> Creating a Service Broker endpoint causes SQL Server to accept TCP/IP connections on the port specified. Service Broker transport security allows you to require authorization for connections to the port. If the computer that runs SQL Server has a firewall enabled, the firewall configuration on that computer must allow both incoming connections for the port specified in the endpoint. For more information on Service Broker transport security, see [Service Broker Transport Security](service-broker-transport-security.md).
21+
22+
### To activate Service Broker networking
1923

2024
- Create a Service Broker endpoint, specifying the port number and the authentication level.
2125

docs/database-engine/service-broker/how-to-configure-initiating-services-for-anonymous-dialog-security-transact-sql.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ ms.date: "03/30/2022"
1414

1515
[!INCLUDE [sql-asdbmi](../../includes/applies-to-version/sql-asdbmi.md)]
1616

17-
SQL Server uses dialog security for any conversation to a service for which a remote service binding exists. If the database that hosts the target service does not contain a user that corresponds to the user that created the dialog, the dialog uses anonymous security.> [!NOTE]
17+
SQL Server uses dialog security for any conversation to a service for which a remote service binding exists. If the database that hosts the target service does not contain a user that corresponds to the user that created the dialog, the dialog uses anonymous security.
18+
19+
> [!NOTE]
1820
> Only install certificates from trusted sources.
1921
2022
## To make sure that an initiating service uses dialog security

docs/database-engine/service-broker/performance.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ Next, end conversations when the task completes. Service Broker maintains state
4141

4242
Finally, keep transactions short. For example, if the conversation pattern for the service involves a large number of messages on the same conversation group, limiting the number of messages processed in each transaction may improve overall throughput.
4343

44-
## See also[Conversation Group Locks](conversation-group-locks.md)
44+
## See also
45+
46+
[Conversation Group Locks](conversation-group-locks.md)
4547

4648
[Message Retention](message-retention.md)

docs/database-engine/service-broker/service-broker-dialog-security.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ When Service Broker establishes a dialog between two databases, the initiating s
8181
The most flexible way to do this is to create a certificate and remote service binding. For more information about creating a certificate, see [CREATE CERTIFICATE (Transact-SQL)](../../t-sql/statements/create-certificate-transact-sql.md). For more information about creating a remote service binding see, [CREATE REMOTE SERVICE BINDING (Transact-SQL)](../../t-sql/statements/create-remote-service-binding-transact-sql.md).
8282

8383
> [!NOTE]
84-
> If the security context is not set up correctly, messages sent on the dialog will stay in the sys.transmission_queue on the initiating service with the following error message in the transmission_status column: **The server principal '%.*ls' is not able to access the database '%.*ls' under the current security context.**
84+
> If the security context is not set up correctly, messages sent on the dialog will stay in the sys.transmission_queue on the initiating service with the following error message in the transmission_status column: **The server principal `'%.*ls'` is not able to access the database `'%.*ls'` under the current security context.**
8585
8686
## See also
8787

0 commit comments

Comments
 (0)