src: return references from getters, not copies

bnoordhuis · BridgeAR · commit 3869dd2a137f · 2017-09-21T19:18:56.000-03:00
PR-URL: nodejs#15458 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/node_perf.h b/src/node_perf.h
@@ -73,11 +73,11 @@ class PerformanceEntry : public BaseObject {
       return env_;
     }
 
-    std::string name() const {
+    const std::string& name() const {
       return name_;
     }
 
-    std::string type() const {
+    const std::string& type() const {
       return type_;
     }
 
@@ -135,11 +135,11 @@ class PerformanceEntry : public BaseObject {
 
   ~PerformanceEntry() {}
 
-  std::string name() const {
+  const std::string& name() const {
     return name_;
   }
 
-  std::string type() const {
+  const std::string& type() const {
     return type_;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -73,11 +73,11 @@ class PerformanceEntry : public BaseObject {`
`73`	`73`	`return env_;`
`74`	`74`	`}`
`75`	`75`
`76`		`- std::string name() const {`
	`76`	`+ const std::string& name() const {`
`77`	`77`	`return name_;`
`78`	`78`	`}`
`79`	`79`
`80`		`- std::string type() const {`
	`80`	`+ const std::string& type() const {`
`81`	`81`	`return type_;`
`82`	`82`	`}`
`83`	`83`
`@@ -135,11 +135,11 @@ class PerformanceEntry : public BaseObject {`
`135`	`135`
`136`	`136`	`~PerformanceEntry() {}`
`137`	`137`
`138`		`- std::string name() const {`
	`138`	`+ const std::string& name() const {`
`139`	`139`	`return name_;`
`140`	`140`	`}`
`141`	`141`
`142`		`- std::string type() const {`
	`142`	`+ const std::string& type() const {`
`143`	`143`	`return type_;`
`144`	`144`	`}`
`145`	`145`