Skip to content

Commit 1bb92ce

Browse files
joyeecheungBenjamin Gruenbaum
authored andcommitted
doc: mention git-node in the collaborator guide
PR-URL: nodejs#18960 Fixes: nodejs#18197 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
1 parent 1460b31 commit 1bb92ce

File tree

1 file changed

+27
-1
lines changed

1 file changed

+27
-1
lines changed

COLLABORATOR_GUIDE.md

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
- [Deprecations](#deprecations)
2222
- [Involving the TSC](#involving-the-tsc)
2323
* [Landing Pull Requests](#landing-pull-requests)
24+
- [Using `git-node`](#using-git-node)
2425
- [Technical HOWTO](#technical-howto)
2526
- [Troubleshooting](#troubleshooting)
2627
- [I Just Made a Mistake](#i-just-made-a-mistake)
@@ -455,6 +456,26 @@ Additionally:
455456
- All commits should be self-contained (meaning every commit should pass all
456457
tests). This makes it much easier when bisecting to find a breaking change.
457458

459+
### Using `git-node`
460+
461+
In most cases, using [the `git-node` command][git-node] of [`node-core-utils`][]
462+
should be enough to help you land a Pull Request. If you discover a problem when
463+
using this tool, please file an issue
464+
[to the issue tracker][node-core-utils-issues].
465+
466+
Quick example:
467+
468+
```text
469+
$ npm install -g node-core-utils
470+
$ git node land $PRID
471+
```
472+
473+
If it's the first time you ever use `node-core-utils`, you will be prompted
474+
to type the password of your GitHub account in the console so the tool can
475+
create the GitHub access token for you. If you do not want to do that, follow
476+
[the guide of `node-core-utils`][node-core-utils-credentials]
477+
to set up your credentials manually.
478+
458479
### Technical HOWTO
459480

460481
Clear any `am`/`rebase` that may already be underway:
@@ -571,7 +592,8 @@ commit logs, ensure that they are properly formatted, and add
571592

572593
<a name="metadata"></a>
573594
* Modify the original commit message to include additional metadata regarding
574-
the change process. ([`node-core-utils`][] fetches the metadata for you.)
595+
the change process. (The [`git node metadata`][git-node-metadata] command
596+
can generate the metadata for you.)
575597

576598
* Required: A `PR-URL:` line that references the *full* GitHub URL of the
577599
original pull request being merged so it's easy to trace a commit back to
@@ -750,6 +772,10 @@ LTS working group and the Release team.
750772
[Stability Index]: doc/api/documentation.md#stability-index
751773
[Enhancement Proposal]: https://github.com/nodejs/node-eps
752774
[`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation
775+
[git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
776+
[git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata
753777
[git-username]: https://help.github.com/articles/setting-your-username-in-git/
754778
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
755779
[TSC]: https://github.com/nodejs/TSC
780+
[node-core-utils-issues]: https://github.com/nodejs/node-core-utils/issues
781+
[node-core-utils-credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials

0 commit comments

Comments
 (0)