src: fix resource leak in node::fs::FileHandle

refack · refack · commit 5ab807db3b68 · 2018-10-24T11:52:22.000-04:00
PR-URL: nodejs#23793 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/src/node_file.h b/src/node_file.h
@@ -406,7 +406,7 @@ class FileHandle : public AsyncWrap, public StreamBase {
       ref_.Reset(env->isolate(), ref);
     }
 
-    ~CloseReq() {
+    ~CloseReq() override {
       uv_fs_req_cleanup(req());
       promise_.Reset();
       ref_.Reset();

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ class FileHandle : public AsyncWrap, public StreamBase {`
`406`	`406`	`ref_.Reset(env->isolate(), ref);`
`407`	`407`	`}`
`408`	`408`
`409`		`- ~CloseReq() {`
	`409`	`+ ~CloseReq() override {`
`410`	`410`	`uv_fs_req_cleanup(req());`
`411`	`411`	`promise_.Reset();`
`412`	`412`	`ref_.Reset();`