Coding Standards: Use strict comparison for normalize_whitespace() checks when comparing revisions or autosaves.

SergeyBiryukov · SergeyBiryukov · commit 38e9142a6628 · 2020-02-25T19:33:22.000Z
Props dkarfa, itowhid06, TimothyBlynJacobs. Fixes #47965. git-svn-id: https://develop.svn.wordpress.org/trunk@47372 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/edit-form-advanced.php b/src/wp-admin/edit-form-advanced.php
@@ -245,7 +245,7 @@
 // Detect if there exists an autosave newer than the post and if that autosave is different than the post.
 if ( $autosave && mysql2date( 'U', $autosave->post_modified_gmt, false ) > mysql2date( 'U', $post->post_modified_gmt, false ) ) {
 	foreach ( _wp_post_revision_fields( $post ) as $autosave_field => $_autosave_field ) {
-		if ( normalize_whitespace( $autosave->$autosave_field ) != normalize_whitespace( $post->$autosave_field ) ) {
+		if ( normalize_whitespace( $autosave->$autosave_field ) !== normalize_whitespace( $post->$autosave_field ) ) {
 			$notice = sprintf(
 				/* translators: %s: URL to view the autosave. */
 				__( 'There is an autosave of this post that is more recent than the version below. <a href="%s">View the autosave</a>' ),
diff --git a/src/wp-admin/includes/post.php b/src/wp-admin/includes/post.php
@@ -1829,7 +1829,7 @@ function wp_create_post_autosave( $post_data ) {
 		// If the new autosave has the same content as the post, delete the autosave.
 		$autosave_is_different = false;
 		foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {
-			if ( normalize_whitespace( $new_autosave[ $field ] ) != normalize_whitespace( $post->$field ) ) {
+			if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {
 				$autosave_is_different = true;
 				break;
 			}
diff --git a/src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php b/src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php
@@ -368,7 +368,7 @@ public function create_post_autosave( $post_data ) {
 			$autosave_is_different = false;
 
 			foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {
-				if ( normalize_whitespace( $new_autosave[ $field ] ) != normalize_whitespace( $post->$field ) ) {
+				if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {
 					$autosave_is_different = true;
 					break;
 				}
diff --git a/src/wp-includes/revision.php b/src/wp-includes/revision.php
@@ -162,7 +162,7 @@ function wp_save_post_revision( $post_id ) {
 			$post_has_changed = false;
 
 			foreach ( array_keys( _wp_post_revision_fields( $post ) ) as $field ) {
-				if ( normalize_whitespace( $post->$field ) != normalize_whitespace( $last_revision->$field ) ) {
+				if ( normalize_whitespace( $post->$field ) !== normalize_whitespace( $last_revision->$field ) ) {
 					$post_has_changed = true;
 					break;
 				}

Original file line number	Diff line number	Diff line change
`@@ -1829,7 +1829,7 @@ function wp_create_post_autosave( $post_data ) {`
`1829`	`1829`	`// If the new autosave has the same content as the post, delete the autosave.`
`1830`	`1830`	`$autosave_is_different = false;`
`1831`	`1831`	`foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {`
`1832`		`- if ( normalize_whitespace( $new_autosave[ $field ] ) != normalize_whitespace( $post->$field ) ) {`
	`1832`	`+ if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {`
`1833`	`1833`	`$autosave_is_different = true;`
`1834`	`1834`	`break;`
`1835`	`1835`	`}`
Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,7 @@ public function create_post_autosave( $post_data ) {`
`368`	`368`	`$autosave_is_different = false;`
`369`	`369`
`370`	`370`	`foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {`
`371`		`- if ( normalize_whitespace( $new_autosave[ $field ] ) != normalize_whitespace( $post->$field ) ) {`
	`371`	`+ if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {`
`372`	`372`	`$autosave_is_different = true;`
`373`	`373`	`break;`
`374`	`374`	`}`
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ function wp_save_post_revision( $post_id ) {`
`162`	`162`	`$post_has_changed = false;`
`163`	`163`
`164`	`164`	`foreach ( array_keys( _wp_post_revision_fields( $post ) ) as $field ) {`
`165`		`- if ( normalize_whitespace( $post->$field ) != normalize_whitespace( $last_revision->$field ) ) {`
	`165`	`+ if ( normalize_whitespace( $post->$field ) !== normalize_whitespace( $last_revision->$field ) ) {`
`166`	`166`	`$post_has_changed = true;`
`167`	`167`	`break;`
`168`	`168`	`}`