fix: Added missing type (feast-dev#4315)

dmartinol · nick-amaya-sp · commit 680e8473c21e · 2024-07-23T09:36:00.000-05:00
Added missing type

Signed-off-by: Daniele Martinoli &lt;86618610+dmartinol@users.noreply.github.com&gt;
diff --git a/sdk/python/feast/diff/registry_diff.py b/sdk/python/feast/diff/registry_diff.py
@@ -20,6 +20,7 @@
     OnDemandFeatureView as OnDemandFeatureViewProto,
 )
 from feast.protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
+from feast.protos.feast.core.SavedDataset_pb2 import SavedDataset as SavedDatasetProto
 from feast.protos.feast.core.StreamFeatureView_pb2 import (
     StreamFeatureView as StreamFeatureViewProto,
 )
@@ -109,6 +110,7 @@ def tag_objects_for_keep_delete_update_add(
     OnDemandFeatureViewProto,
     StreamFeatureViewProto,
     ValidationReferenceProto,
+    SavedDatasetProto,
 )
 
 
diff --git a/sdk/python/feast/feast_object.py b/sdk/python/feast/feast_object.py
@@ -11,11 +11,12 @@
 from .protos.feast.core.FeatureService_pb2 import FeatureServiceSpec
 from .protos.feast.core.FeatureView_pb2 import FeatureViewSpec
 from .protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
+from .protos.feast.core.SavedDataset_pb2 import SavedDatasetSpec
 from .protos.feast.core.StreamFeatureView_pb2 import StreamFeatureViewSpec
 from .protos.feast.core.ValidationProfile_pb2 import (
     ValidationReference as ValidationReferenceProto,
 )
-from .saved_dataset import ValidationReference
+from .saved_dataset import SavedDataset, ValidationReference
 from .stream_feature_view import StreamFeatureView
 
 # Convenience type representing all Feast objects
@@ -28,6 +29,7 @@
     FeatureService,
     DataSource,
     ValidationReference,
+    SavedDataset,
 ]
 
 FeastObjectSpecProto = Union[
@@ -38,4 +40,5 @@
     FeatureServiceSpec,
     DataSourceProto,
     ValidationReferenceProto,
+    SavedDatasetSpec,
 ]

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`OnDemandFeatureView as OnDemandFeatureViewProto,`
`21`	`21`	`)`
`22`	`22`	`from feast.protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec`
	`23`	`+from feast.protos.feast.core.SavedDataset_pb2 import SavedDataset as SavedDatasetProto`
`23`	`24`	`from feast.protos.feast.core.StreamFeatureView_pb2 import (`
`24`	`25`	`StreamFeatureView as StreamFeatureViewProto,`
`25`	`26`	`)`
`@@ -109,6 +110,7 @@ def tag_objects_for_keep_delete_update_add(`
`109`	`110`	`OnDemandFeatureViewProto,`
`110`	`111`	`StreamFeatureViewProto,`
`111`	`112`	`ValidationReferenceProto,`
	`113`	`+ SavedDatasetProto,`
`112`	`114`	`)`
`113`	`115`
`114`	`116`