feat(typings): mark void methods in angular2.d.ts

alexeagle · alexeagle · commit a56d33d7ca19 · 2015-07-06T17:25:59.000-07:00
Previously, when a return type was missing it could have been any. But following angular#2746 we require return types so remaining untyped returns must be void.
diff --git a/docs/dgeni-package/templates/type-definition.template.html b/docs/dgeni-package/templates/type-definition.template.html
@@ -43,7 +43,7 @@
     {$ member.name $}
     {%- if member.optional %}?{% endif -%}
     {%- if member.parameters %}({% for param in member.parameters %}{$ param $}{% if not loop.last %}, {% endif %}{% endfor %}){%- endif %}
-    {%- if member.returnType %}: {$ member.returnType $}{%- else -%}: any{% endif -%}
+    {%- if member.returnType %}: {$ member.returnType $}{%- else -%}: void{% endif -%}
     ;
   {%- endfor %}
   }
diff --git a/modules/angular2/src/forms/directives/ng_model.ts b/modules/angular2/src/forms/directives/ng_model.ts
@@ -63,7 +63,7 @@ export class NgModel extends NgControl {
     }
   }
 
-  get control() { return this._control; }
+  get control(): Control { return this._control; }
 
   get path(): List<string> { return []; }
 

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@`
`43`	`43`	`{$ member.name $}`
`44`	`44`	`{%- if member.optional %}?{% endif -%}`
`45`	`45`	`{%- if member.parameters %}({% for param in member.parameters %}{$ param $}{% if not loop.last %}, {% endif %}{% endfor %}){%- endif %}`
`46`		`- {%- if member.returnType %}: {$ member.returnType $}{%- else -%}: any{% endif -%}`
	`46`	`+ {%- if member.returnType %}: {$ member.returnType $}{%- else -%}: void{% endif -%}`
`47`	`47`	`;`
`48`	`48`	`{%- endfor %}`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ export class NgModel extends NgControl {`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`
`66`		`- get control() { return this._control; }`
	`66`	`+ get control(): Control { return this._control; }`
`67`	`67`
`68`	`68`	`get path(): List<string> { return []; }`
`69`	`69`