Implement equals/hashCode for Filters

Vlatombe · Vlatombe · commit 51c580ed0ec8 · 2015-10-13T11:20:11.000+02:00
diff --git a/src/main/java/com/github/dockerjava/api/model/Filters.java b/src/main/java/com/github/dockerjava/api/model/Filters.java
@@ -92,6 +92,22 @@ private static List<String> labelsMapToList(Map<String, String> labels) {
         return result;
     }
 
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+
+        Filters filters1 = (Filters) o;
+
+        return filters.equals(filters1.filters);
+
+    }
+
+    @Override
+    public int hashCode() {
+        return filters.hashCode();
+    }
+
     @Override
     public String toString() {
         try {
@@ -100,4 +116,5 @@ public String toString() {
             throw new RuntimeException(e);
         }
     }
+
 }
diff --git a/src/test/java/com/github/dockerjava/api/model/FiltersTest.java b/src/test/java/com/github/dockerjava/api/model/FiltersTest.java
@@ -0,0 +1,43 @@
+package com.github.dockerjava.api.model;
+
+import com.google.common.collect.Maps;
+import org.testng.annotations.Test;
+
+import java.util.Map;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotSame;
+
+/**
+ * @author Vincent Latombe <vincent@latombe.net>
+ */
+public class FiltersTest {
+
+    @Test
+    public void newFiltersShouldBeEquals() {
+        assertEquals(new Filters(), new Filters());
+    }
+
+    @Test
+    public void filtersWithEqualContentShouldBeEquals() {
+        assertEquals(new Filters().withContainers("foo"), new Filters().withContainers("foo"));
+        assertEquals(new Filters().withLabels("alpha=val"), new Filters().withLabels("alpha=val"));
+    }
+
+    @Test
+    public void withLabelsMapShouldBeEquivalentToVarargs() {
+        Map<String, String> map = Maps.newHashMap();
+        map.put("alpha", "val");
+        assertEquals(new Filters().withLabels("alpha=val"), new Filters().withLabels(map));
+
+        map = Maps.newHashMap();
+        map.put("alpha", "val");
+        map.put("beta", "val1");
+        assertEquals(new Filters().withLabels("alpha=val", "beta=val1"), new Filters().withLabels(map));
+    }
+
+    @Test
+    public void filtersWithDifferentContentShouldntBeEquals() {
+        assertNotSame(new Filters().withContainers("foo"), new Filters().withContainers("bar"));
+    }
+}
