adap tests etc

hjwp · hjwp · commit ea2dafcac910 · 2021-02-24T22:01:50.000Z
diff --git a/src/allocation/domain/model.py b/src/allocation/domain/model.py
@@ -17,6 +17,16 @@ def allocate(line: OrderLine, batches: List[Batch]) -> str:
         raise OutOfStock(f"Out of stock for sku {line.sku}")
 
 
+class Product:
+    """ dummy implementation, fixme"""
+
+    def __init__(self, *args, **kwargs):
+        self.batches = kwargs.get("batches")
+
+    def allocate(self, line):
+        return allocate(line, self.batches)
+
+
 @dataclass(unsafe_hash=True)
 class OrderLine:
     orderid: str
diff --git a/tests/integration/test_uow.py b/tests/integration/test_uow.py
@@ -10,10 +10,9 @@
 
 
 def insert_batch(session, ref, sku, qty, eta, product_version=1):
-    session.execute(
-        "INSERT INTO products (sku, version_number) VALUES (:sku, :version)",
-        dict(sku=sku, version=product_version),
-    )
+    # session.execute(
+    #     'INSERT INTO products ...?
+    # )
     session.execute(
         "INSERT INTO batches (reference, sku, _purchased_quantity, eta)"
         " VALUES (:ref, :sku, :qty, :eta)",
@@ -88,6 +87,7 @@ def try_to_allocate(orderid, sku, exceptions):
         exceptions.append(e)
 
 
+@pytest.mark.skip("do this for an advanced challenge")
 def test_concurrent_updates_to_version_are_not_allowed(postgres_session_factory):
     sku, batch = random_sku(), random_batchref()
     session = postgres_session_factory()
diff --git a/tests/unit/test_product.py b/tests/unit/test_product.py
@@ -51,6 +51,7 @@ def test_raises_out_of_stock_exception_if_cannot_allocate():
         product.allocate(OrderLine("order2", "SMALL-FORK", 1))
 
 
+@pytest.mark.skip
 def test_increments_version_number():
     line = OrderLine("oref", "SCANDI-PEN", 10)
     product = Product(
diff --git a/tests/unit/test_services.py b/tests/unit/test_services.py
@@ -4,14 +4,17 @@
 
 
 class FakeRepository(repository.AbstractRepository):
-    def __init__(self, products):
-        self._products = set(products)
+    def __init__(self, batches):
+        self._batches = set(batches)
 
-    def add(self, product):
-        self._products.add(product)
+    def add(self, batch):
+        self._batches.add(batch)
 
     def get(self, sku):
-        return next((p for p in self._products if p.sku == sku), None)
+        return next((p for p in self._batches if p.sku == sku), None)
+
+    def list(self):
+        return list(self._batches)
 
 
 class FakeUnitOfWork(unit_of_work.AbstractUnitOfWork):
