stop caring about quantity. someone elses problem

hjwp · hjwp · commit 6f727d8ac06c · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -10,7 +10,6 @@ def skus(d):
 
 def allocate_line(sku, quantity, source, allocations):
     if source.get(sku, 0) > quantity:
-        source[sku] -= quantity
         allocations[sku] = source
 
 
diff --git a/test_allocation.py b/test_allocation.py
@@ -19,7 +19,6 @@ def test_can_allocate_to_stock():
     allocations = allocate(order, stock, shipments=[])
 
     assert allocations['a-sku'] == stock
-    assert stock['a-sku'] == 990
 
 
 def test_can_allocate_to_shipment():
@@ -31,7 +30,6 @@ def test_can_allocate_to_shipment():
     allocations = allocate(order, stock={}, shipments=[shipment])
 
     assert allocations['a-sku'] == shipment
-    assert shipment['a-sku'] == 990
 
 
 def test_ignores_irrelevant_stock():
@@ -44,8 +42,6 @@ def test_ignores_irrelevant_stock():
     allocations = allocate(order, stock=stock, shipments=[shipment])
 
     assert allocations['sku1'] == shipment
-    assert stock['sku2'] == 1000
-    assert shipment['sku1'] == 990
 
 
 def test_can_allocate_to_correct_shipment():
@@ -60,8 +56,6 @@ def test_can_allocate_to_correct_shipment():
     allocations = allocate(order, stock={}, shipments=[shipment1, shipment2])
 
     assert allocations['sku2'] == shipment2
-    assert shipment1['sku1'] == 1000
-    assert shipment2['sku2'] == 990
 
 
 def test_allocates_to_stock_in_preference_to_shipment():
@@ -74,8 +68,6 @@ def test_allocates_to_stock_in_preference_to_shipment():
     allocations = allocate(order, stock, shipments=[shipment])
 
     assert allocations['sku1'] == stock
-    assert stock['sku1'] == 990
-    assert shipment['sku1'] == 1000
 
 
 def test_can_allocate_multiple_lines_to_wh():
@@ -85,8 +77,6 @@ def test_can_allocate_multiple_lines_to_wh():
     allocations = allocate(order, stock, shipments=[])
     assert allocations['sku1'] == stock
     assert allocations['sku2'] == stock
-    assert stock['sku1'] == 995
-    assert stock['sku2'] == 990
 
 
 def test_can_allocate_multiple_lines_to_shipment():
@@ -100,8 +90,6 @@ def test_can_allocate_multiple_lines_to_shipment():
 
     assert allocations['sku1'] == shipment
     assert allocations['sku2'] == shipment
-    assert shipment['sku1'] == 995
-    assert shipment['sku2'] == 990
 
 
 def test_can_allocate_to_both():
@@ -115,8 +103,6 @@ def test_can_allocate_to_both():
 
     assert allocations['sku1'] == stock
     assert allocations['sku2'] == shipment
-    assert stock['sku1'] == 995
-    assert shipment['sku2'] == 990
 
 
 def test_can_allocate_to_both_preferring_stock():
@@ -134,11 +120,6 @@ def test_can_allocate_to_both_preferring_stock():
     assert allocations['sku2'] == shipment
     assert allocations['sku3'] == stock
     assert allocations['sku4'] == stock
-    assert shipment['sku1'] == 999
-    assert shipment['sku2'] == 998
-    assert shipment['sku3'] == 1000
-    assert stock['sku3'] == 997
-    assert stock['sku4'] == 996
 
 
 def test_mixed_allocations_are_avoided_if_possible():
@@ -231,15 +212,3 @@ def test_cannot_allocate_if_insufficent_quantity_in_shipment():
 
     assert 'a-sku' not in allocations
 
-
-def test_cannot_allocate_more_orders_than_we_have_stock_for():
-    order1 = {'a-sku': 10}
-    order2 = {'a-sku': 10}
-    stock = {'a-sku': 15}
-
-    allocations1 = allocate(order1, stock, shipments=[])
-    allocations2 = allocate(order2, stock, shipments=[])
-
-    assert 'a-sku' in allocations1
-    assert 'a-sku' not in allocations2
-
