Correctly restore connection if MySQL server has gone away (GoogleCloudPlatform#2421)

bramus · andrewferlitsch · commit f3fb377aaefc · 2019-10-07T09:58:46.000-07:00
diff --git a/functions/sql/mysql_sample.py b/functions/sql/mysql_sample.py
@@ -46,11 +46,9 @@ def __get_cursor():
       PyMySQL does NOT automatically reconnect,
       so we must reconnect explicitly using ping()
     """
-    try:
-        return mysql_conn.cursor()
-    except OperationalError:
+    if not mysql_conn.open:
         mysql_conn.ping(reconnect=True)
-        return mysql_conn.cursor()
+    return mysql_conn.cursor()
 
 
 def mysql_demo(request):
