style: address newly reported rubocop offenses

jcouball · jcouball · commit a37412d6a1cf · 2026-03-31T09:24:59.000-07:00
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -45,6 +45,10 @@ Style/Documentation:
   Exclude:
     - "tests/units/**/*"
 
+Style/OneClassPerFile:
+  Exclude:
+    - "tests/units/**/*"
+
 AllCops:
   # Pin this project to Ruby 3.1 in case the shared config above is upgraded to 3.2
   # or later.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -9,4 +9,4 @@
 # Offense count: 2
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 1160
+  Max: 1170
diff --git a/lib/git.rb b/lib/git.rb
@@ -43,7 +43,7 @@ module Git
 #
 # @author Scott Chacon (mailto:schacon@gmail.com)
 #
-module Git
+module Git # rubocop:disable Style/OneClassPerFile
   # g.config('user.name', 'Scott Chacon') # sets value
   # g.config('user.email', 'email@email.com')  # sets value
   # g.config('user.name')  # returns 'Scott Chacon'
diff --git a/lib/git/command_line.rb b/lib/git/command_line.rb
@@ -242,7 +242,7 @@ def run_with_capture_options(**options_hash)
     # @api private
     #
     def build_git_cmd(args)
-      raise ArgumentError, 'The args array can not contain an array' if args.any? { |a| a.is_a?(Array) }
+      raise ArgumentError, 'The args array can not contain an array' if args.any?(Array)
 
       [binary_path, *global_opts, *args].map(&:to_s)
     end
diff --git a/lib/git/diff.rb b/lib/git/diff.rb
@@ -133,7 +133,7 @@ def blob(type = :dst)
     private
 
     def validate_paths_not_arrays(paths)
-      return unless paths.any? { |p| p.is_a?(Array) }
+      return unless paths.any?(Array)
 
       raise ArgumentError,
             'path expects individual arguments, not arrays. ' \
diff --git a/lib/git/status.rb b/lib/git/status.rb
@@ -80,11 +80,7 @@ def ignore_case?
     rescue Git::FailedError
       @_ignore_case = false
     end
-  end
-end
 
-module Git
-  class Status
     # Represents a single file's status in the git repository. Each instance
     # holds information about a file's state in the index and working tree.
     class StatusFile
@@ -109,11 +105,7 @@ def blob(type = :index)
         @base.object(sha) if sha
       end
     end
-  end
-end
 
-module Git
-  class Status
     # A factory class responsible for fetching git status data and building
     # a hash of StatusFile objects.
     # @api private

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ module Git`
`43`	`43`	`#`
`44`	`44`	`# @author Scott Chacon (mailto:schacon@gmail.com)`
`45`	`45`	`#`
`46`		`-module Git`
	`46`	`+module Git # rubocop:disable Style/OneClassPerFile`
`47`	`47`	`# g.config('user.name', 'Scott Chacon') # sets value`
`48`	`48`	`# g.config('user.email', 'email@email.com') # sets value`
`49`	`49`	`# g.config('user.name') # returns 'Scott Chacon'`
Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ def run_with_capture_options(**options_hash)`
`242`	`242`	`# @api private`
`243`	`243`	`#`
`244`	`244`	`def build_git_cmd(args)`
`245`		`- raise ArgumentError, 'The args array can not contain an array' if args.any? { \|a\| a.is_a?(Array) }`
	`245`	`+ raise ArgumentError, 'The args array can not contain an array' if args.any?(Array)`
`246`	`246`
`247`	`247`	`[binary_path, global_opts, args].map(&:to_s)`
`248`	`248`	`end`