From 932539b15232f0e1a2168008f6d2395cf96a70cd Mon Sep 17 00:00:00 2001 From: Kaan Ozdogan <48806820+Lethalos@users.noreply.github.com> Date: Mon, 3 Oct 2022 00:31:06 +0300 Subject: [PATCH 1/9] Update style.css Update keys flex property --- 01 - JavaScript Drum Kit/style.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/01 - JavaScript Drum Kit/style.css b/01 - JavaScript Drum Kit/style.css index bfdba84312..290ee0d1ce 100644 --- a/01 - JavaScript Drum Kit/style.css +++ b/01 - JavaScript Drum Kit/style.css @@ -12,13 +12,13 @@ body,html { .keys { display: flex; - flex: 1; min-height: 100vh; align-items: center; justify-content: center; } .key { + flex: 1; border: .4rem solid black; border-radius: .5rem; margin: 1rem; From 10388a59c22d2d0428147acb8497c68ca574a5aa Mon Sep 17 00:00:00 2001 From: Hamna R Date: Fri, 25 Nov 2022 20:05:08 +0500 Subject: [PATCH 2/9] sticky nav on multiple screens is fixed by the height in px --- 24 - Sticky Nav/style-FINISHED.css | 2 +- 24 - Sticky Nav/style-START.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/24 - Sticky Nav/style-FINISHED.css b/24 - Sticky Nav/style-FINISHED.css index 0f8df57cb9..2d36a02ba1 100644 --- a/24 - Sticky Nav/style-FINISHED.css +++ b/24 - Sticky Nav/style-FINISHED.css @@ -31,7 +31,7 @@ body.fixed-nav .site-wrap { header { text-align: center; - height: 50vh; + height: 500px; background: url(https://source.unsplash.com/GKN6rpDr0EI/960x640) bottom center no-repeat; background-size: cover; display: flex; diff --git a/24 - Sticky Nav/style-START.css b/24 - Sticky Nav/style-START.css index ef2bc15845..0049a2f597 100644 --- a/24 - Sticky Nav/style-START.css +++ b/24 - Sticky Nav/style-START.css @@ -27,7 +27,7 @@ body { header { text-align: center; - height: 50vh; + height: 500px; background: url(https://source.unsplash.com/GKN6rpDr0EI/960x640) bottom center no-repeat; background-size: cover; display: flex; From a89f7633af116e2ca18335ba88f3423347747541 Mon Sep 17 00:00:00 2001 From: Clavis7 <96084919+Clavis7@users.noreply.github.com> Date: Sat, 10 Dec 2022 19:04:06 +0530 Subject: [PATCH 3/9] Removed a button element The empty button just before script tag is confusing. There is no need for it in the start file as Wes already wrote this element in the end section of tutorial. --- .../index-START.html | 1 - 1 file changed, 1 deletion(-) diff --git a/25 - Event Capture, Propagation, Bubbling and Once/index-START.html b/25 - Event Capture, Propagation, Bubbling and Once/index-START.html index 7bd5931e01..094cb20b8b 100644 --- a/25 - Event Capture, Propagation, Bubbling and Once/index-START.html +++ b/25 - Event Capture, Propagation, Bubbling and Once/index-START.html @@ -40,7 +40,6 @@ } - From a23f7ec27479ffb23f473693d3565e9aac813299 Mon Sep 17 00:00:00 2001 From: aaronbiu <459852675@qq.com> Date: Tue, 7 Jan 2025 20:29:05 +0800 Subject: [PATCH 4/9] Add my project link in the readme (#699) --- readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/readme.md b/readme.md index 4212cb16c8..584068db0e 100644 --- a/readme.md +++ b/readme.md @@ -14,6 +14,7 @@ Feel free to submit a PR by adding a link to your own recaps, guides, or reviews * [Nitish Dayal's Text Guides](https://github.com/nitishdayal/JavaScript30) are great for those who like reading over watching. * [Thorsten Frommen](https://tfrommen.de/tag/javascript-30/) shares how he solved the exercises before viewing the answers. * [Soyaine 写的中文指南](https://github.com/soyaine/JavaScript30)包含了过程记录和难点解释 +* [Aaron的语雀学习小组](https://github.com/A-aronYang/JavaScript30)包含中文文档，案例和相关资料 * [乔木 录制的讲解视频](https://b23.tv/pSa7rdu) 看中文讲解视频一起学习 Javascript30 吧! Javascript30 中 CSS/JS/HTML 视频讲解 * [Ayo Isaiah's](https://freshman.tech/archive/#javascript30) Recaps and Lessons Learned. * [Adriana Rios](https://stpcollabr8nlstn.github.io/JavaScript30/) shares her alternative solutions. From 40e9d1255d4f232363a3dedc89311f07793308ca Mon Sep 17 00:00:00 2001 From: yoanastamenova Date: Fri, 21 Mar 2025 16:14:15 +0100 Subject: [PATCH 5/9] fix: project 3 image source loading --- 03 - CSS Variables/index-FINISHED.html | 2 +- 03 - CSS Variables/index-START.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/03 - CSS Variables/index-FINISHED.html b/03 - CSS Variables/index-FINISHED.html index b52b9f61af..36f5bf1ac6 100644 --- a/03 - CSS Variables/index-FINISHED.html +++ b/03 - CSS Variables/index-FINISHED.html @@ -19,7 +19,7 @@

Update CSS Variables with JS

- +