Guard the log calls

mttkay · mttkay · commit 2f0670ecc6fd · 2014-03-12T18:31:12.000+01:00
diff --git a/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperatorWeakBinding.java b/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperatorWeakBinding.java
@@ -87,18 +87,24 @@ private boolean shouldForwardNotification(Subscriber<? super T> sub) {
 
         private void handleLostBinding(Subscriber<? super T> sub, String context) {
             if (sub == null) {
-                Log.d(LOG_TAG, "subscriber gone; skipping " + context);
+                log("subscriber gone; skipping " + context);
             } else {
                 final R r = boundRef.get();
                 if (r != null) {
                     // the predicate failed to validate
-                    Log.d(LOG_TAG, "bound component has become invalid; skipping " + context);
+                    log("bound component has become invalid; skipping " + context);
                 } else {
-                    Log.d(LOG_TAG, "bound component gone; skipping " + context);
+                    log("bound component gone; skipping " + context);
                 }
             }
-            Log.d(LOG_TAG, "unsubscribing...");
+            log("unsubscribing...");
             unsubscribe();
         }
+
+        private void log(String message) {
+            if (Log.isLoggable(LOG_TAG, Log.DEBUG)) {
+                Log.d(LOG_TAG, message);
+            }
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -87,18 +87,24 @@ private boolean shouldForwardNotification(Subscriber<? super T> sub) {`
`87`	`87`
`88`	`88`	`private void handleLostBinding(Subscriber<? super T> sub, String context) {`
`89`	`89`	`if (sub == null) {`
`90`		`- Log.d(LOG_TAG, "subscriber gone; skipping " + context);`
	`90`	`+ log("subscriber gone; skipping " + context);`
`91`	`91`	`} else {`
`92`	`92`	`final R r = boundRef.get();`
`93`	`93`	`if (r != null) {`
`94`	`94`	`// the predicate failed to validate`
`95`		`- Log.d(LOG_TAG, "bound component has become invalid; skipping " + context);`
	`95`	`+ log("bound component has become invalid; skipping " + context);`
`96`	`96`	`} else {`
`97`		`- Log.d(LOG_TAG, "bound component gone; skipping " + context);`
	`97`	`+ log("bound component gone; skipping " + context);`
`98`	`98`	`}`
`99`	`99`	`}`
`100`		`- Log.d(LOG_TAG, "unsubscribing...");`
	`100`	`+ log("unsubscribing...");`
`101`	`101`	`unsubscribe();`
`102`	`102`	`}`
	`103`	`+`
	`104`	`+ private void log(String message) {`
	`105`	`+ if (Log.isLoggable(LOG_TAG, Log.DEBUG)) {`
	`106`	`+ Log.d(LOG_TAG, message);`
	`107`	`+ }`
	`108`	`+ }`
`103`	`109`	`}`
`104`	`110`	`}`