Example bug in metadata handling

The java code sometimes uses the flag, and sometimes uses metadata.length() instead. So if they don't agree bad things happen.

  @Test
  public void testEncodingNullMetadata() {
    int encoded =
            RequestFrameFlyweight.encode(
                    byteBuf,
                    1,
                    FrameHeaderFlyweight.FLAGS_M,
                    FrameType.REQUEST_STREAM,
                    1,
                    Unpooled.copiedBuffer("", StandardCharsets.UTF_8),
                    Unpooled.copiedBuffer("d", StandardCharsets.UTF_8));
    assertEquals(
            "00000b0000000119000000000164", bufToString(encoded));

    PayloadImpl payload = new PayloadImpl(Frame.from(stringToBuf("00000b0000000119000000000164")));

    assertEquals("", StandardCharsets.UTF_8.decode(payload.getMetadata()).toString());
  }

  private String bufToString(int encoded) {
    return ByteBufUtil.hexDump(byteBuf, 0, encoded);
  }

  private ByteBuf stringToBuf(CharSequence s) {
    return Unpooled.wrappedBuffer(ByteBufUtil.decodeHexDump(s));
  }

Uh oh!

rsocket-js to rsocket-java doesn't work if null metadata sent #353

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions