Improve logging in src/tasks/Common/Utils.cs (dotnet#52545)

akoeplinger · web-flow · commit d37eeef9635a · 2021-05-10T19:26:33.000+02:00
Fixes dotnet#52447
diff --git a/src/tasks/Common/Utils.cs b/src/tasks/Common/Utils.cs
@@ -94,9 +94,9 @@ public static string RunProcess(
 
         if (process.ExitCode != 0)
         {
-            Logger?.LogMessage(MessageImportance.Low, $"Exit code: {process.ExitCode}");
+            Logger?.LogMessage(MessageImportance.High, $"Exit code: {process.ExitCode}");
             if (!ignoreErrors)
-                throw new Exception("Error: " + errorBuilder);
+                throw new Exception("Error: Process returned non-zero exit code: " + errorBuilder);
         }
 
         return outputBuilder.ToString().Trim('\r', '\n');

Original file line number	Diff line number	Diff line change
`@@ -94,9 +94,9 @@ public static string RunProcess(`
`94`	`94`
`95`	`95`	`if (process.ExitCode != 0)`
`96`	`96`	`{`
`97`		`- Logger?.LogMessage(MessageImportance.Low, $"Exit code: {process.ExitCode}");`
	`97`	`+ Logger?.LogMessage(MessageImportance.High, $"Exit code: {process.ExitCode}");`
`98`	`98`	`if (!ignoreErrors)`
`99`		`- throw new Exception("Error: " + errorBuilder);`
	`99`	`+ throw new Exception("Error: Process returned non-zero exit code: " + errorBuilder);`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`return outputBuilder.ToString().Trim('\r', '\n');`