fix: Avoid the python 3.9+ threadpool cleanup bug (feast-dev#4627)

robhowley · robhowley · commit 431c011e8a27 · 2024-10-15T20:38:28.000-04:00
fix: dont allow for new refresh threadpool tasks to start during shutdown

Signed-off-by: Rob Howley &lt;howley.robert@gmail.com&gt;
diff --git a/sdk/python/feast/feature_server.py b/sdk/python/feast/feature_server.py
@@ -125,11 +125,12 @@ def stop_refresh():
             active_timer.cancel()
 
     def async_refresh():
+        if shutting_down:
+            return
+
         store.refresh_registry()
         nonlocal registry_proto
         registry_proto = store.registry.proto()
-        if shutting_down:
-            return
 
         if registry_ttl_sec:
             nonlocal active_timer
@@ -244,8 +245,12 @@ def write_to_online_store(body=Depends(get_body)):
         )
 
     @app.get("/health")
-    def health():
-        return Response(status_code=status.HTTP_200_OK)
+    async def health():
+        return (
+            Response(status_code=status.HTTP_200_OK)
+            if registry_proto
+            else Response(status_code=status.HTTP_503_SERVICE_UNAVAILABLE)
+        )
 
     @app.post("/materialize", dependencies=[Depends(inject_user_details)])
     def materialize(body=Depends(get_body)):
