Skip to content

Commit 7f96af8

Browse files
author
Sascha Schumann
committed
Stop automatically passing vars to AC_SUBST through PHP_SUBST.
There are some variables which are needed for Makefiles and files created by AC_OUTPUT; we use PHP_SUBST_OLD for those now. genif.sh was moved to an appropiate place.
1 parent 060e647 commit 7f96af8

7 files changed

Lines changed: 16 additions & 17 deletions

File tree

acinclude.m4

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,10 @@ fi
321321

322322
AC_DEFUN(PHP_SUBST,[
323323
PHP_VAR_SUBST="$PHP_VAR_SUBST $1"
324+
])
325+
326+
AC_DEFUN(PHP_SUBST_OLD,[
327+
PHP_SUBST($1)
324328
AC_SUBST($1)
325329
])
326330

genif.sh renamed to build/genif.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#! /bin/sh
22

3-
# $Id: genif.sh,v 1.10 2000-12-20 16:29:07 sas Exp $
3+
# $Id: genif.sh,v 1.1 2000-12-20 17:21:37 sas Exp $
44
# replacement for genif.pl
55

66
infile="$1"
@@ -27,7 +27,7 @@ for ext in ${1+"$@"} ; do
2727
header_list="$header_list ext/$ext/*.h"
2828
done
2929

30-
includes=`$awk -f $srcdir/build/print_include.awk $header_list`
30+
includes=`$awk -f ./build/print_include.awk $header_list`
3131

3232
cd $olddir
3333

configure.in

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -579,11 +579,6 @@ if test "$PHP_PEAR" = "yes"; then
579579
PEAR_DIR=pear
580580
fi
581581
582-
PHP_OUTPUT(pear/pear)
583-
PHP_OUTPUT(pear/phpize)
584-
PHP_OUTPUT(pear/php-config)
585-
PHP_OUTPUT(pear/PEAR.php)
586-
587582
588583
divert(5)
589584
@@ -668,7 +663,6 @@ EXTRA_LDFLAGS="$EXTRA_LDFLAGS $LDFLAGS"
668663
EXTRA_LIBS="$EXTRA_LIBS $LIBS"
669664
LDFLAGS=""
670665
LIBS=""
671-
PHP_OUTPUT(TSRM/Makefile)
672666
673667
674668
phplibdir="`pwd`/modules"
@@ -762,7 +756,7 @@ PHP_SUBST(SHARED_LIBTOOL)
762756
PHP_SUBST(TSRM_DIR)
763757
PHP_SUBST(TSRM_LIB)
764758
PHP_SUBST(WARNING_LEVEL)
765-
PHP_SUBST(YACC)
759+
PHP_SUBST_OLD(YACC)
766760
767761
PHP_CONFIGURE_PART(Configuring libtool)
768762
@@ -824,7 +818,8 @@ PHP_CONFIGURE_PART(Generating files)
824818
825819
PHP_GEN_CONFIG_VARS
826820
827-
ALL_OUTPUT_FILES="php4.spec Zend/Makefile main/build-defs.h $PHP_OUTPUT_FILES"
821+
ALL_OUTPUT_FILES="php4.spec Zend/Makefile main/build-defs.h \
822+
pear/pear pear/phpize pear/php-config pear/PEAR.php TSRM/Makefile $PHP_OUTPUT_FILES"
828823
829824
AC_OUTPUT($ALL_OUTPUT_FILES, [], [
830825
@@ -863,9 +858,9 @@ if test -n "\$REDO_ALL"; then
863858
# Hacking while airborne considered harmful.
864859
#
865860
echo "creating main/internal_functions.c"
866-
extensions=\`grep '^s.@EXT_STATIC@' \$0|sed -e 's/^.*@% *//' -e 's/%.*$//'\`
861+
extensions="$EXT_STATIC"
867862
dnl mv -f main/internal_functions.c main/internal_functions.c.old 2>/dev/null
868-
sh $srcdir/genif.sh $srcdir/main/internal_functions.c.in $srcdir "$EXTRA_MODULE_PTRS" $AWK \$extensions > main/internal_functions.c
863+
sh $srcdir/build/genif.sh $srcdir/main/internal_functions.c.in $srcdir "$EXTRA_MODULE_PTRS" $AWK \$extensions > main/internal_functions.c
869864
dnl if cmp main/internal_functions.c.old main/internal_functions.c > /dev/null 2>&1; then
870865
dnl echo "main/internal_functions.c is unchanged"
871866
dnl mv main/internal_functions.c.old main/internal_functions.c

ext/oci8/config.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,5 +80,5 @@ if test "$PHP_OCI8" != "no"; then
8080

8181
PHP_SUBST(OCI8_SHARED_LIBADD)
8282
PHP_SUBST(OCI8_DIR)
83-
PHP_SUBST(OCI8_VERSION)
83+
PHP_SUBST_OLD(OCI8_VERSION)
8484
fi

ext/odbc/config.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,6 @@ if test -n "$ODBC_TYPE"; then
470470
PHP_SUBST(ODBC_LIBDIR)
471471
PHP_SUBST(ODBC_LIBS)
472472
PHP_SUBST(ODBC_LFLAGS)
473-
PHP_SUBST(ODBC_TYPE)
473+
PHP_SUBST_OLD(ODBC_TYPE)
474474
PHP_EXTENSION(odbc, $shared)
475475
fi

ext/oracle/config.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,5 +156,5 @@ if test "$PHP_ORACLE" != "no"; then
156156

157157
PHP_SUBST(ORACLE_SHARED_LIBADD)
158158
PHP_SUBST(ORACLE_DIR)
159-
PHP_SUBST(ORACLE_VERSION)
159+
PHP_SUBST_OLD(ORACLE_VERSION)
160160
fi

sapi/cgi/config.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,5 @@ AC_ARG_WITH(fhttpd,
6464
])
6565
INCLUDES="$INCLUDES $FHTTPD_INCLUDE"
6666
dnl## AC_SUBST(FHTTPD_INCLUDE)
67-
AC_SUBST(FHTTPD_LIB)
68-
AC_SUBST(FHTTPD_TARGET)
67+
PHP_SUBST(FHTTPD_LIB)
68+
PHP_SUBST(FHTTPD_TARGET)

0 commit comments

Comments
 (0)