py: Fix handling of negative numbers in struct.pack of q/Q.

dpgeorge · dpgeorge · commit 9472907ae190 · 2015-04-25T23:51:14.000+01:00
diff --git a/py/binary.c b/py/binary.c
@@ -291,6 +291,10 @@ void mp_binary_set_val(char struct_type, char val_type, mp_obj_t val_in, byte **
             #endif
             {
                 val = mp_obj_get_int(val_in);
+                // sign extend if needed
+                if (BYTES_PER_WORD < 8 && size > sizeof(val) && is_signed(val_type) && (mp_int_t)val < 0) {
+                    memset(p + sizeof(val), 0xff, size - sizeof(val));
+                }
             }
     }
 
diff --git a/py/mpz.c b/py/mpz.c
@@ -1441,8 +1441,8 @@ void mpz_as_bytes(const mpz_t *z, bool big_endian, mp_uint_t len, byte *buf) {
         for (; bits >= 8; bits -= 8, d >>= 8) {
             mpz_dig_t val = d;
             if (z->neg) {
-                d = (~d & 0xff) + carry;
-                carry = d >> 8;
+                val = (~val & 0xff) + carry;
+                carry = val >> 8;
             }
             if (big_endian) {
                 *--b = val;

Original file line number	Diff line number	Diff line change
`@@ -291,6 +291,10 @@ void mp_binary_set_val(char struct_type, char val_type, mp_obj_t val_in, byte **`
`291`	`291`	`#endif`
`292`	`292`	`{`
`293`	`293`	`val = mp_obj_get_int(val_in);`
	`294`	`+ // sign extend if needed`
	`295`	`+ if (BYTES_PER_WORD < 8 && size > sizeof(val) && is_signed(val_type) && (mp_int_t)val < 0) {`
	`296`	`+ memset(p + sizeof(val), 0xff, size - sizeof(val));`
	`297`	`+ }`
`294`	`298`	`}`
`295`	`299`	`}`
`296`	`300`