Skip to content

Commit e30ebfe

Browse files
jiaxiSteve Martinelli
authored andcommitted
Add volume type show for volume v1
volume type show is missing for volume V1 API. Closes-Bug: #1475879 Change-Id: Ic8a0845ecec04146d536412463175f57ef6511ae
1 parent fcadb16 commit e30ebfe

2 files changed

Lines changed: 25 additions & 0 deletions

File tree

openstackclient/volume/v1/type.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,3 +182,27 @@ def take_action(self, parsed_args):
182182
else:
183183
self.app.log.error("No changes requested\n")
184184
return
185+
186+
187+
class ShowVolumeType(show.ShowOne):
188+
"""Display volume type details"""
189+
190+
log = logging.getLogger(__name__ + ".ShowVolumeType")
191+
192+
def get_parser(self, prog_name):
193+
parser = super(ShowVolumeType, self).get_parser(prog_name)
194+
parser.add_argument(
195+
"volume_type",
196+
metavar="<volume-type>",
197+
help="Volume type to display (name or ID)"
198+
)
199+
return parser
200+
201+
def take_action(self, parsed_args):
202+
self.log.debug("take_action: (%s)", parsed_args)
203+
volume_client = self.app.client_manager.volume
204+
volume_type = utils.find_resource(
205+
volume_client.volume_types, parsed_args.volume_type)
206+
properties = utils.format_dict(volume_type._info.pop('extra_specs'))
207+
volume_type._info.update({'properties': properties})
208+
return zip(*sorted(six.iteritems(volume_type._info)))

setup.cfg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,7 @@ openstack.volume.v1 =
365365
volume_type_list = openstackclient.volume.v1.type:ListVolumeType
366366
volume_type_set = openstackclient.volume.v1.type:SetVolumeType
367367
volume_type_unset = openstackclient.volume.v1.type:UnsetVolumeType
368+
volume_type_show = openstackclient.volume.v1.type:ShowVolumeType
368369

369370
volume_qos_associate = openstackclient.volume.v1.qos_specs:AssociateQos
370371
volume_qos_create = openstackclient.volume.v1.qos_specs:CreateQos

0 commit comments

Comments
 (0)