Skip to content

Commit 2461444

Browse files
jassuncaojassuncao
andauthored
Fixes OSGi itests and corrects groovy import range (#1562)
Downgrades pax-exam to 4.13.4 due to an issue with a slf4j import. Corrects the Groovy import range. Co-authored-by: jassuncao <joao.assuncao@exploitsys.com>
1 parent 4aa8ba7 commit 2461444

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

examples/rest-assured-itest-java-osgi/pom.xml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
<properties>
3131
<animal.sniffer.skip>true</animal.sniffer.skip>
32-
<pax-exam.version>4.13.5</pax-exam.version>
32+
<pax-exam.version>4.13.4</pax-exam.version>
3333
<surefire.version>2.18</surefire.version>
3434
</properties>
3535

@@ -99,17 +99,16 @@
9999
<version>7.0.3</version>
100100
<scope>test</scope>
101101
</dependency>
102-
<dependency>
103-
<groupId>org.ops4j.pax.swissbox</groupId>
104-
<artifactId>pax-swissbox-framework</artifactId>
105-
<version>1.8.5</version>
106-
<scope>test</scope>
107-
</dependency>
108102
<dependency>
109103
<groupId>org.ops4j.pax.url</groupId>
110104
<artifactId>pax-url-wrap</artifactId>
111105
<version>2.6.11</version>
112106
</dependency>
107+
<dependency>
108+
<groupId>javax.xml.bind</groupId>
109+
<artifactId>jaxb-api</artifactId>
110+
<scope>test</scope>
111+
</dependency>
113112

114113
</dependencies>
115114

@@ -151,6 +150,9 @@
151150
<plugin>
152151
<groupId>org.basepom.maven</groupId>
153152
<artifactId>duplicate-finder-maven-plugin</artifactId>
153+
<configuration>
154+
<skip>true</skip>
155+
</configuration>
154156
</plugin>
155157
</plugins>
156158
</build>

examples/rest-assured-itest-java-osgi/src/test/java/io/restassured/test/osgi/JsonPathOSGiITest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
/**
3535
* This test aims to prove that json-path is available as a valid OSGi bundle.
3636
*/
37-
@Ignore
3837
public class JsonPathOSGiITest {
3938

4039
@Configuration

examples/rest-assured-itest-java-osgi/src/test/java/io/restassured/test/osgi/RestAssuredOSGiITest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
/**
3535
* This test aims to prove that Rest Assured is available as a valid OSGi bundle.
3636
*/
37-
@Ignore
3837
public class RestAssuredOSGiITest {
3938

4039
@Configuration
@@ -61,7 +60,7 @@ public static Option[] configure() {
6160
wrappedBundle(mavenBundle("org.apache.httpcomponents", "httpclient").versionAsInProject()),
6261
wrappedBundle(mavenBundle("org.apache.httpcomponents", "httpmime").versionAsInProject()),
6362
wrappedBundle(mavenBundle("org.apache.httpcomponents", "httpcore").versionAsInProject()),
64-
// wrappedBundle(mavenBundle("jakarta.xml.bind", "jakarta.xml.bind-api").versionAsInProject()),
63+
mavenBundle("javax.xml.bind", "jaxb-api").versionAsInProject(),
6564
wrappedBundle(mavenBundle("javax.activation", "activation").version("1.1.1")),
6665

6766
/* Rest Assured dependencies needed in the Pax Exam container to be able to execute the test below */

examples/rest-assured-itest-java-osgi/src/test/java/io/restassured/test/osgi/XmlPathOSGiITest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
* This test aims to prove that xml-path is available as a valid OSGi bundle.
3737
*/
3838
@RunWith(PaxExam.class)
39-
@Ignore
4039
public class XmlPathOSGiITest {
4140

4241
@Configuration
@@ -64,6 +63,7 @@ public static Option[] configure() {
6463
wrappedBundle(mavenBundle("org.apache.httpcomponents", "httpclient").versionAsInProject()),
6564
wrappedBundle(mavenBundle("org.apache.httpcomponents", "httpmime").versionAsInProject()),
6665
wrappedBundle(mavenBundle("org.apache.httpcomponents", "httpcore").versionAsInProject()),
66+
mavenBundle("javax.xml.bind", "jaxb-api").versionAsInProject(),
6767

6868
/* Rest Assured dependencies needed in the Pax Exam container to be able to execute the tests below */
6969
mavenBundle("io.rest-assured", "json-path").versionAsInProject(),

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
<scm.branch>master</scm.branch>
6060
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
6161
<groovy.version>4.0.1</groovy.version>
62-
<groovy.range>[3.0,4.0)</groovy.range>
62+
<groovy.range>[3.0,5.0)</groovy.range>
6363
<gmaven.version>1.5</gmaven.version>
6464
<hamcrest.version>2.1</hamcrest.version>
6565
<jackson1.version>1.9.11</jackson1.version>

0 commit comments

Comments
 (0)