Dedicatedhost#Cancel: cli bug with --immediate flag

Yingchao Huang · Yingchao Huang · commit b773b59b947e · 2018-10-17T14:24:43.000-07:00
We found weird behavior with cancellation if we set `--immediate default=True` in decorator.

`slcli dedicatedhost cancel ID`   =&gt; will create immediate cancellation ticket
`slcli dedicatedhost cancel ID --immediate` =&gt; will create non-immediate cancellation ticket
Have no idea what is the root cause, fix is to enforce `immediate = True` in function body.
diff --git a/SoftLayer/CLI/dedicatedhost/cancel.py b/SoftLayer/CLI/dedicatedhost/cancel.py
@@ -21,8 +21,8 @@
 @click.option('--reason',
               help="An optional cancellation reason. See cancel-reasons for a list of available options")
 @environment.pass_env
-def cli(env, identifier, comment, reason, immediate=True):
+def cli(env, identifier, immediate, comment, reason):
     """Cancel a dedicated server."""
-
+    immediate = True  # Enforce immediate cancellation
     mgr = SoftLayer.DedicatedHostManager(env.client)
     mgr.cancel_host(identifier, reason, comment, immediate)
