BugFix npgsql#198 NpgsqlParameter with Type NpgsqlTimeStampTZ is not inserted with TimeZone prefix (e.g. +00)

mw · mw · commit b51be83f8d20 · 2014-04-03T08:25:16.000+02:00
diff --git a/Npgsql/Npgsql/NpgsqlCommand.Rewrite.cs b/Npgsql/Npgsql/NpgsqlCommand.Rewrite.cs
@@ -610,7 +610,7 @@ private void AppendParameterValues(Stream dest)
 
         private void AppendParameterValue(Stream dest, NpgsqlParameter parameter)
         {
-            byte[] serialised = parameter.TypeInfo.ConvertToBackend(parameter.Value, false, Connector.NativeToBackendTypeConverterOptions);
+            byte[] serialised = parameter.TypeInfo.ConvertToBackend(parameter.NpgsqlValue, false, Connector.NativeToBackendTypeConverterOptions);
 
             // Add parentheses wrapping parameter value before the type cast to avoid problems with Int16.MinValue, Int32.MinValue and Int64.MinValue
             // See bug #1010543
diff --git a/tests/CommandTests.cs b/tests/CommandTests.cs
@@ -1248,6 +1248,36 @@ public void ProviderDateTimeSupportTimezone3()
             }
         }
 
+        [Test]
+        public void ProviderDateTimeSupportTimezone4()
+        {
+            ExecuteNonQuery("SET TIME ZONE 5"); //Should not be equal to your local time zone !
+
+            NpgsqlTimeStampTZ tsInsert = new NpgsqlTimeStampTZ(2014, 3, 28, 10, 0, 0, NpgsqlTimeZone.UTC);
+            
+            using (var command = new NpgsqlCommand("INSERT INTO data(field_timestamp_with_timezone) VALUES (:p1)", Conn))
+            {
+                var p1 = command.Parameters.Add("p1", NpgsqlDbType.TimestampTZ);
+                p1.Direction = ParameterDirection.Input;
+                p1.Value = tsInsert;
+                
+                command.ExecuteNonQuery();
+            }
+            
+
+            using (var command = new NpgsqlCommand("SELECT field_timestamp_with_timezone FROM data", Conn))
+            {
+                NpgsqlTimeStampTZ tsSelect;
+                using (var reader = command.ExecuteReader())
+                {
+                    reader.Read();
+                    tsSelect = reader.GetTimeStampTZ(0);
+                }
+
+                Assert.AreEqual(tsInsert.AtTimeZone(NpgsqlTimeZone.UTC), tsSelect.AtTimeZone(NpgsqlTimeZone.UTC));
+            }
+        }
+
         [Test]
         public void DoubleValueSupportWithExtendedQuery()
         {

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@ private void AppendParameterValues(Stream dest)`
`610`	`610`
`611`	`611`	`private void AppendParameterValue(Stream dest, NpgsqlParameter parameter)`
`612`	`612`	`{`
`613`		`- byte[] serialised = parameter.TypeInfo.ConvertToBackend(parameter.Value, false, Connector.NativeToBackendTypeConverterOptions);`
	`613`	`+ byte[] serialised = parameter.TypeInfo.ConvertToBackend(parameter.NpgsqlValue, false, Connector.NativeToBackendTypeConverterOptions);`
`614`	`614`
`615`	`615`	`// Add parentheses wrapping parameter value before the type cast to avoid problems with Int16.MinValue, Int32.MinValue and Int64.MinValue`
`616`	`616`	`// See bug #1010543`