Merge pull request apache#853 from datastax/python-836

beltran · web-flow · commit 52834b3ad604 · 2017-11-16T11:20:12.000+01:00
Test delay can be zero in ConstantSpeculativeExecutionPolicy
diff --git a/tests/integration/standard/test_policies.py b/tests/integration/standard/test_policies.py
@@ -12,21 +12,23 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from tests.integration import use_singledc
-
 try:
     import unittest2 as unittest
 except ImportError:
     import unittest  # noqa
 
-from cassandra.cluster import Cluster, ExecutionProfile
-from cassandra.policies import HostFilterPolicy, RoundRobinPolicy,  SimpleConvictionPolicy, WhiteListRoundRobinPolicy
+from cassandra.cluster import Cluster, ExecutionProfile, ResponseFuture
+from cassandra.policies import HostFilterPolicy, RoundRobinPolicy,  SimpleConvictionPolicy, \
+    WhiteListRoundRobinPolicy, ConstantSpeculativeExecutionPolicy
 from cassandra.pool import Host
+from cassandra.query import SimpleStatement
 
 from tests.integration import PROTOCOL_VERSION, local
+from tests.integration import use_singledc
 
+from unittest.mock import patch
 from concurrent.futures import wait as wait_futures
-
+from itertools import count
 
 def setup_module():
     use_singledc()
@@ -36,7 +38,7 @@ class HostFilterPolicyTests(unittest.TestCase):
 
     def test_predicate_changes(self):
         """
-        Test to validate hostfilter reacts correctly when the predicate return
+        Test to validate host filter reacts correctly when the predicate return
         a different subset of the hosts
         HostFilterPolicy
         @since 3.8
@@ -91,3 +93,30 @@ def test_only_connects_to_subset(self):
             queried_hosts.update(response.response_future.attempted_hosts)
         queried_hosts = set(host.address for host in queried_hosts)
         self.assertEqual(queried_hosts, only_connect_hosts)
+
+
+class SpeculativeExecutionPolicy(unittest.TestCase):
+    def test_delay_can_be_0(self):
+        """
+        Test to validate that the delay can be zero for the ConstantSpeculativeExecutionPolicy
+        @since 3.13
+        @jira_ticket PYTHON-836
+        @expected_result all the queries are executed immediately
+        @test_category policy
+        """
+        number_of_requests = 6
+        spec = ExecutionProfile(speculative_execution_policy=ConstantSpeculativeExecutionPolicy(0, number_of_requests))
+
+        cluster = Cluster()
+        cluster.add_execution_profile("spec", spec)
+        session = cluster.connect(wait_for_all_pools=True)
+        self.addCleanup(cluster.shutdown)
+
+        with patch.object(ResponseFuture, "_on_speculative_execute",
+                          side_effect=ResponseFuture._on_speculative_execute,
+                          autospec=True) as on_speculative_mocked:
+            stmt = SimpleStatement("INSERT INTO test3rf.test(k, v) VALUES (1, 2)")
+            stmt.is_idempotent = True
+            results = session.execute(stmt, execution_profile="spec")
+            self.assertEqual(len(results.response_future.attempted_hosts), 3)
+            self.assertEqual(on_speculative_mocked.call_count, number_of_requests)
