fix(sticky-notifications-actions): avoid initial offset#9868
fix(sticky-notifications-actions): avoid initial offset#9868AbdelrahmanHafez wants to merge 1 commit into
sticky-notifications-actions): avoid initial offset#9868Conversation
sticky-notifications-actions): avoid initial offset
|
Nope. This will cause #9761 most likely it just needs a margin:0 or something. |
|
You're right, I confirmed that this fixes the issue, but clipping overflows is rarely the right fix. In this case, the issue is this line: Setting it to 0 fixes it, but first we need to figure out why it's not already zero and if that fix breaks anything. |
|
I added a hotfix, not sure why GitHub decided to close the PR |
|
@fregante thanks for the hotfix. One thing I noticed is that the hotfix currently deployed remains broken for a second when I first open the notifications page, and then the bar moves to the correct place, unlike clipping the overflow. Any chance we can use this PR as a hotfix until we find a proper solution? Screen.Recording.2026-07-22.at.11.58.14.AM.mov |
|
The delay is due to the hotfix loading, not the property. I will include a fix in the next release of Refined GitHub, but that will happen maybe in a week. |
|
Great, thanks! |
closes #9866
I used GPT-5.6-Sol on Extra High to solve this, and confirmed it works.
GitHub's
.overflow-hiddenclass turns the notification box into a scroll container, so the sticky action bar'stop: 10pxoffset is applied before the page scrolls.This changes the box to
overflow: clip, which keeps the rounded box clipped without creating a scroll container. The action bar stays in its normal position until it becomes sticky.Test URLs
https://github.com/notifications
Screenshot