quick-comment-edit - Restore on issue pages#9754
Conversation
|
Ready for review. I'll keep it as a draft for a day in case I find any issues or think of any improvements |
Greetings; I installed the latest artifact with this PR merged, https://github.com/refined-github/refined-github/actions/runs/27976624476?pr=9754 but I quickly stumbled upon a bug when using GitHub issue URLs with "comment" fragments, e.g. e3kskoy7wqk/Firefox-for-windows-7#159 (comment) Browser is Firefox-140esr (32-bit) When I use the artifact from https://github.com/refined-github/refined-github/actions/runs/27866249527?pr=9747 and follow these STR: a) open a new blank tab e3kskoy7wqk/Firefox-for-windows-7#159 (comment) the browser indeed identifies and scroll-stops to the referenced comment (which is focused), the last one in that thread as I type this: However, once I install https://github.com/refined-github/refined-github/actions/runs/27976624476?pr=9754 and repeat the same above STR, the tab's scroll bar moves down then up, with the tab in the end displaying the opening post of the thread (not the specified in the URL fragment, last one) : Also, the I receive e-mail notifications for new comments on GitHub issues I follow and my usual workflow involves clicking the "view it on GitHub" link at the bottom, which is actually a URL with a comment number as its fragment: While I do like the Thanks for your coding efforts 👍 , best regards. |
|
Thank you, should be fixed now |
quick-comment-edit - Support issuesquick-comment-edit - Restore on issue pages
Fixes #9123
Test URLs
#9123
Screenshot