Skip to content

actionable-pr-view-file - Restore feature#9140

Draft
SunsetTechuila wants to merge 7 commits intomainfrom
act-pr-file-restore
Draft

actionable-pr-view-file - Restore feature#9140
SunsetTechuila wants to merge 7 commits intomainfrom
act-pr-file-restore

Conversation

@SunsetTechuila
Copy link
Copy Markdown
Member

exclude: [
// Editing files doesn't make sense after a PR is closed/merged
pageDetect.isClosedConversation,
() => elementExists(deletedHeadRepository),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of those checks?

https://github.com/search?q=repo%3Arefined-github%2Frefined-github%20elementExists(deletedHeadRepository)&type=code

If head branch is deleted, the PR will be automatically closed

Copy link
Copy Markdown
Member

@fregante fregante Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it still behaves this way, but you can delete a fork even if there are open PRs from it. The PRs stay open and uneditable. The commits still exist "floating in the ether" so the native links still work.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently they changed the behavior, so feel free to drop this condition refined-github/sandbox#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

actionable-pr-view-file broken

2 participants