Seperate issue / pr links (#id) from linkify-code #5063

Activity

1. amithm7

   added

   enhancement

   under discussion

   on Nov 10, 2021
2. kidonng commented on Nov 10, 2021

   

   kidonng

   on Nov 10, 2021

   Last edited by kidonng

   Member

   More actions

   than making a hyperlink of a URL which already exists in the code.

   To me it is the other way around, links in code comments are enormous and nobody wants to manually select and open via context menu/drag and drop all the time.

   For example, this feature could be called linkify-hash-id maybe ?

   And would linkify #5063 in code comments but not example.com

   First, it's not "hash id" but "number sign and number".
   Second, we are unlikely to split it into two features that are pretty much the same Implementation.

   👀React with 👀1Reacted by Amith Mohanan
3. amithm7 commented on Nov 10, 2021

   

   amithm7

   on Nov 10, 2021

   Last edited by amithm7

   Author

   More actions

   code comments are enormous

   Some maybe, but you can't select and right-click #5063 to open it.

   it's not "hash id" but "number sign and number".

   Never heard of "number sign", I see that it's what used in USA maybe? Never been there.
   id because it identifies a PR / Issue.

   we are unlikely to split it into two features that are pretty much the same Implementation.

   Implementation maybe but I am asking for a different option for each.
   Edit: I see separate implementations.
4. fregante commented on Nov 10, 2021

   

   fregante

   on Nov 10, 2021

   Member

   More actions

   As far as Refined GitHub is concerned, we want to linkify both, so we don't split features just to increase granularity. Splitting the feature would duplicate a lot of code and lower performance. For example there's a simple watcher/loop that calls those 2 functions; If we split the feature, we'd need 2 watchers… and then both of them will be enabled by default.

   Also I don't see the need to split this specific feature; If you don't want to click full links, don't click them.
5. fregante

   closed this as completedon Nov 10, 2021
6. amithm7 commented on Nov 10, 2021

   

   amithm7

   on Nov 10, 2021

   Author

   More actions

   @fregante , linkify-code can remain, but it can have sub-features, right?

   linkify-code
     |_ urls
     |_ issues
   

   Also, the preferences / options page needs some organization.

   👎React with 👎1Reacted by yakov116
7. kidonng commented on Nov 10, 2021

   

   kidonng

   on Nov 10, 2021

   Member

   More actions

   @fregante , linkify-code can remain, but it can have sub-features, right?

   linkify-code
     |_ urls
     |_ issues
   

   Please keep the conversation constructive. As mentioned above this is a very niche request and we are not going to support it.

   If you really want it, please consider maintaing a fork yourself (it's not difficult and can be automated).

   Also, the preferences / options page needs some organization.

   Organized feature descriptions with categories are present in the README.

   👍React with 👍1Reacted by Amith Mohanan