Description
Follow-up to #9907 / #9916 — the fix landed in v26.8.8, but the pull-request-hotkeys feature appears broken again for me.
Console error:
ElementNotFoundError: Expected elements not found because the base is specified but null
at select-dom.js:10:1
Confirmed via DevTools console on a live PR page:
[...document.querySelectorAll('nav[aria-label], [role="tablist"]')].map(el => el.getAttribute('aria-label'))
// -> ["Breadcrumbs", "Repository", "Pull request navigation", "Add a comment", "Footer"]
No element matches "Pull request tabs" or "Pull request navigation tabs", which is what pull-request-hotkeys.tsx currently searches for via elementReady. It looks like GitHub renamed the tab nav's aria-label again to just "Pull request navigation" (at least on the Conversation/Commits sub-pages — /files still showed the old "Pull request tabs" label in a separate check).
I was not able to capture a full call stack proving this exact error originates from pull-request-hotkeys.js specifically (Firefox only logs the message + throw location for this case, not a full stack), so I can't be 100% certain this is the culprit — flagging this explicitly in case it's unrelated.
How to replicate the issue + URL
#9916
- Open the URL above (or any PR conversation page) in Firefox with Refined GitHub enabled.
- Press
g then 1 (or 2, 3, ...) to jump to a PR tab.
- Nothing happens; the console shows the
ElementNotFoundError above.
Extension version
v26.8.8
Browser(s) used
Firefox v140.14.0esr (64-bit)
Token ⚠️
Description
Follow-up to #9907 / #9916 — the fix landed in v26.8.8, but the
pull-request-hotkeysfeature appears broken again for me.Console error:
Confirmed via DevTools console on a live PR page:
No element matches
"Pull request tabs"or"Pull request navigation tabs", which is whatpull-request-hotkeys.tsxcurrently searches for viaelementReady. It looks like GitHub renamed the tab nav'saria-labelagain to just"Pull request navigation"(at least on the Conversation/Commits sub-pages —/filesstill showed the old"Pull request tabs"label in a separate check).I was not able to capture a full call stack proving this exact error originates from
pull-request-hotkeys.jsspecifically (Firefox only logs the message + throw location for this case, not a full stack), so I can't be 100% certain this is the culprit — flagging this explicitly in case it's unrelated.How to replicate the issue + URL
#9916
gthen1(or2,3, ...) to jump to a PR tab.ElementNotFoundErrorabove.Extension version
v26.8.8
Browser(s) used
Firefox v140.14.0esr (64-bit)
Token⚠️