Lint and minor console errors fixes (#2869)

yakov116 · fregante · web-flow · commit bcd6cc49912c · 2020-03-07T00:50:03.000+03:00
Co-authored-by: Federico Brigante &lt;github@bfred.it&gt;
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -1,4 +1,4 @@
-<!-- 
+<!--
 
 Thanks for contributing! 🍄
 
diff --git a/source/features/hide-navigation-hover-highlight.css b/source/features/hide-navigation-hover-highlight.css
@@ -1,5 +1,5 @@
 .rgh-no-navigation-highlight .list-group-item.navigation-focus, /* Notifications list */
 .rgh-no-navigation-highlight .Box-row.navigation-focus, /* Issue list */
-.rgh-no-navigation-highlight .navigation-focus td { /* File list  */
+.rgh-no-navigation-highlight .navigation-focus td { /* File list */
 	background: none !important;
 }
diff --git a/source/features/improve-shortcut-help.tsx b/source/features/improve-shortcut-help.tsx
@@ -45,9 +45,14 @@ const observer = new MutationObserver(([{target}]) => {
 });
 
 function init(): void {
-	document.addEventListener('keypress', ({key}) => {
-		if (key === '?') {
-			observer.observe(select('body > details > details-dialog')!, {childList: true});
+	document.addEventListener('keypress', ({key, target}) => {
+		if (key !== '?' || target instanceof HTMLTextAreaElement || target instanceof HTMLInputElement) {
+			return;
+		}
+
+		const modal = select('body > details > details-dialog');
+		if (modal) {
+			observer.observe(modal, {childList: true});
 		}
 	});
 }
diff --git a/source/features/pr-branches.tsx b/source/features/pr-branches.tsx
@@ -108,6 +108,10 @@ async function init(): Promise<false | void> {
 	]);
 
 	for (const prLink of prLinks) {
+		if (!data.repository[prLink.id].headOwner) { // 👻 @ghost user
+			return;
+		}
+
 		let branches;
 		let {base, head} = normalizeBranchInfo(data.repository[prLink.id]);
 
diff --git a/source/features/selection-in-new-tab.tsx b/source/features/selection-in-new-tab.tsx
@@ -18,7 +18,7 @@ function init(): void {
 
 features.add({
 	id: __featureName__,
-	description: 'Adds a keyboard shortcut to open selection in new tab when navigating via  `j` and `k`: `Shift` `o`.',
+	description: 'Adds a keyboard shortcut to open selection in new tab when navigating via `j` and `k`: `Shift` `o`.',
 	screenshot: false,
 	shortcuts: {
 		'shift o': 'Open selection in new tab'
diff --git a/source/features/tags-dropdown.css b/source/features/tags-dropdown.css
@@ -6,7 +6,7 @@
 
 /* Make dropdown smaller, if possible */
 :root .rgh-tags-dropdown .select-menu-modal {
-	width: max-content;  /* Default: 300px */
+	width: max-content; /* Default: 300px */
 	min-width: 150px;
 	max-width: 300px;
 }
diff --git a/source/libs/api.ts b/source/libs/api.ts
@@ -6,7 +6,7 @@ next to the name of the feature that caused them.
 Usage:
 
 import * as api from '../libs/api';
-const user  = await api.v3(`users/${username}`);
+const user = await api.v3(`users/${username}`);
 const data = await api.v4('{user(login: "user") {name}}');
 
 Returns:

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<!--`
	`1`	`+<!--`
`2`	`2`
`3`	`3`	`Thanks for contributing! 🍄`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`.rgh-no-navigation-highlight .list-group-item.navigation-focus, /* Notifications list */`
`2`	`2`	`.rgh-no-navigation-highlight .Box-row.navigation-focus, /* Issue list */`
`3`		`-.rgh-no-navigation-highlight .navigation-focus td { /* File list */`
	`3`	`+.rgh-no-navigation-highlight .navigation-focus td { /* File list */`
`4`	`4`	`background: none !important;`
`5`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`/* Make dropdown smaller, if possible */`
`8`	`8`	`:root .rgh-tags-dropdown .select-menu-modal {`
`9`		`- width: max-content; /* Default: 300px */`
	`9`	`+ width: max-content; /* Default: 300px */`
`10`	`10`	`min-width: 150px;`
`11`	`11`	`max-width: 300px;`
`12`	`12`	`}`