vm: simplify Script constructor options validation

cjihrig · refack · commit 360f7400f66c · 2019-01-10T10:04:08.000-05:00
This commit combines two related if statements into an if-else statement. PR-URL: nodejs#25054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/vm.js b/lib/vm.js
@@ -44,8 +44,7 @@ class Script extends ContextifyScript {
     code = `${code}`;
     if (typeof options === 'string') {
       options = { filename: options };
-    }
-    if (typeof options !== 'object' || options === null) {
+    } else if (typeof options !== 'object' || options === null) {
       throw new ERR_INVALID_ARG_TYPE('options', 'Object', options);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,7 @@ class Script extends ContextifyScript {`
`44`	`44`	code = `${code}`;
`45`	`45`	`if (typeof options === 'string') {`
`46`	`46`	`options = { filename: options };`
`47`		`- }`
`48`		`- if (typeof options !== 'object' \|\| options === null) {`
	`47`	`+ } else if (typeof options !== 'object' \|\| options === null) {`
`49`	`48`	`throw new ERR_INVALID_ARG_TYPE('options', 'Object', options);`
`50`	`49`	`}`
`51`	`50`