test,async_hooks: skip whether TTY is available

trevnorris · refack · commit 250d50b3802f · 2017-07-12T14:44:41.000-04:00
If TTY isn't available then the test will always fail. Also use the already available process.stdin instead of opening another ReadStream. PR-URL: nodejs#13991 Fixes: nodejs#13984 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
diff --git a/test/async-hooks/test-ttywrap.readstream.js b/test/async-hooks/test-ttywrap.readstream.js
@@ -1,4 +1,5 @@
 'use strict';
+
 const common = require('../common');
 const assert = require('assert');
 
@@ -10,31 +11,33 @@ const { checkInvocations } = require('./hook-checks');
 const hooks = initHooks();
 hooks.enable();
 
+if (!process.stdin.isTTY)
+  return common.skip('no valid readable TTY available');
+
 // test specific setup
-const { ReadStream } = require('tty');
 const checkInitOpts = { init: 1 };
 const checkEndedOpts = { init: 1, before: 1, after: 1, destroy: 1 };
 
 // test code
 //
 // listen to stdin except on Windows
-const targetFD = common.isWindows ? 1 : 0;
-const ttyStream = new ReadStream(targetFD);
 const activities = hooks.activitiesOfTypes('TTYWRAP');
 assert.strictEqual(activities.length, 1);
+
 const tty = activities[0];
 assert.strictEqual(tty.type, 'TTYWRAP');
 assert.strictEqual(typeof tty.uid, 'number');
 assert.strictEqual(typeof tty.triggerAsyncId, 'number');
 checkInvocations(tty, checkInitOpts, 'when tty created');
+
 const delayedOnCloseHandler = common.mustCall(() => {
   checkInvocations(tty, checkEndedOpts, 'when tty ended');
 });
-ttyStream.on('error', (err) => assert.fail(err));
-ttyStream.on('close', common.mustCall(() =>
+process.stdin.on('error', (err) => assert.fail(err));
+process.stdin.on('close', common.mustCall(() =>
   tick(2, delayedOnCloseHandler)
 ));
-ttyStream.destroy();
+process.stdin.destroy();
 checkInvocations(tty, checkInitOpts, 'when tty.end() was invoked');
 
 process.on('exit', () => {
