zlib: do not unref() if wasn't ref()ed

indutny · piscisaureus · commit 0d02515d6eb2 · 2015-01-10T22:32:12.000+01:00
In very unlikely case, where `deflateInit2()` may return error (right now happening only on exhausting all memory), the `ZCtx::Error()` will be called and will try to `Unref()` the handle. But the problem is that this handle was never `Ref()`ed, so it will trigger an assertion error and crash the program. Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: nodejs/node-v0.x-archive#8687 Cherry-picked-from: nodejs/node-v0.x-archive@8c86898
diff --git a/src/node_zlib.cc b/src/node_zlib.cc
@@ -358,8 +358,9 @@ class ZCtx : public AsyncWrap {
     ctx->MakeCallback(env->onerror_string(), ARRAY_SIZE(args), args);
 
     // no hope of rescue.
+    if (ctx->write_in_progress_)
+      ctx->Unref();
     ctx->write_in_progress_ = false;
-    ctx->Unref();
     if (ctx->pending_close_)
       ctx->Close();
   }
