Fixed potential resource leak of library handle (found by Coverity, CID 989315)

fancycode · fancycode · commit 0f6bdc7c16dd · 2013-03-05T00:30:25.000+01:00
diff --git a/MemoryModule.c b/MemoryModule.c
@@ -257,6 +257,7 @@ BuildImportTable(PMEMORYMODULE module)
 
 			module->modules = (HMODULE *)realloc(module->modules, (module->numModules+1)*(sizeof(HMODULE)));
 			if (module->modules == NULL) {
+				FreeLibrary(handle);
 				result = 0;
 				break;
 			}
@@ -284,6 +285,7 @@ BuildImportTable(PMEMORYMODULE module)
 			}
 
 			if (!result) {
+				FreeLibrary(handle);
 				break;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -257,6 +257,7 @@ BuildImportTable(PMEMORYMODULE module)`
`257`	`257`
`258`	`258`	`module->modules = (HMODULE )realloc(module->modules, (module->numModules+1)(sizeof(HMODULE)));`
`259`	`259`	`if (module->modules == NULL) {`
	`260`	`+ FreeLibrary(handle);`
`260`	`261`	`result = 0;`
`261`	`262`	`break;`
`262`	`263`	`}`
`@@ -284,6 +285,7 @@ BuildImportTable(PMEMORYMODULE module)`
`284`	`285`	`}`
`285`	`286`
`286`	`287`	`if (!result) {`
	`288`	`+ FreeLibrary(handle);`
`287`	`289`	`break;`
`288`	`290`	`}`
`289`	`291`	`}`