Improved error messages

ankane · ankane · commit 12370bb0b4d7 · 2024-06-25T17:45:39.000-07:00
diff --git a/pgvector/utils/sparsevec.py b/pgvector/utils/sparsevec.py
@@ -8,17 +8,17 @@ class SparseVector:
     def __init__(self, value, dimensions=NO_DEFAULT, /):
         if value.__class__.__module__.startswith('scipy.sparse.'):
             if dimensions is not NO_DEFAULT:
-                raise ValueError('dimensions not allowed')
+                raise ValueError('extra argument')
 
             self._from_sparse(value)
         elif isinstance(value, dict):
             if dimensions is NO_DEFAULT:
-                raise ValueError('dimensions required')
+                raise ValueError('missing dimensions')
 
             self._from_dict(value, dimensions)
         else:
             if dimensions is not NO_DEFAULT:
-                raise ValueError('dimensions not allowed')
+                raise ValueError('extra argument')
 
             self._from_dense(value)
 
diff --git a/tests/test_sparse_vector.py b/tests/test_sparse_vector.py
@@ -14,7 +14,7 @@ def test_list(self):
     def test_list_dimensions(self):
         with pytest.raises(ValueError) as error:
             SparseVector([1, 0, 2, 0, 3, 0], 6)
-        assert str(error.value) == 'dimensions not allowed'
+        assert str(error.value) == 'extra argument'
 
     def test_ndarray(self):
         vec = SparseVector(np.array([1, 0, 2, 0, 3, 0]))
@@ -29,7 +29,7 @@ def test_dict(self):
     def test_dict_no_dimensions(self):
         with pytest.raises(ValueError) as error:
             SparseVector({0: 1, 2: 2, 4: 3})
-        assert str(error.value) == 'dimensions required'
+        assert str(error.value) == 'missing dimensions'
 
     def test_coo_array(self):
         arr = coo_array(np.array([1, 0, 2, 0, 3, 0]))
@@ -40,7 +40,7 @@ def test_coo_array(self):
     def test_coo_array_dimensions(self):
         with pytest.raises(ValueError) as error:
             SparseVector(coo_array(np.array([1, 0, 2, 0, 3, 0])), 6)
-        assert str(error.value) == 'dimensions not allowed'
+        assert str(error.value) == 'extra argument'
 
     def test_dok_array(self):
         arr = coo_array(np.array([1, 0, 2, 0, 3, 0])).todok()
