Problem
In a few places, variables that hold service users are named users, user, or currentUser. That name suggests the human user domain, which is a different thing in Frontier. It is easy to misread.
PR #1719 already fixed this in internal/bootstrap/bootstrapuser.go (the ServiceUserCreator param was renamed users → serviceUsers). This issue tracks the same cleanup for pre-existing code, kept out of that PR to avoid unrelated churn.
Known spots
internal/api/v1beta1connect/serviceuser.go — ListServiceUsers: var users []*frontierv1beta1.ServiceUser and for _, user := range usersList (~lines 43-57)
internal/api/v1beta1connect/project.go — var users []serviceuser.ServiceUser and var transformedUsers []*frontierv1beta1.ServiceUser (~lines 249, 257)
internal/store/postgres/serviceuser_repository.go — var transformedUsers []serviceuser.ServiceUser (~line 219)
core/serviceuser/service.go — currentUser for the service user in Sudo/UnSudo (~lines 459-548)
Worth a quick repo-wide sweep for more, e.g.:
grep -rnE "\b(users|user|currentUser)\b.*(serviceuser\.ServiceUser|frontierv1beta1\.ServiceUser)" --include="*.go" .
Suggested naming
Follow the existing convention: serviceUsers for slices, serviceUser (or su in short loops) for single values.
Rename only — no behavior change.
Problem
In a few places, variables that hold service users are named
users,user, orcurrentUser. That name suggests the humanuserdomain, which is a different thing in Frontier. It is easy to misread.PR #1719 already fixed this in
internal/bootstrap/bootstrapuser.go(theServiceUserCreatorparam was renamedusers→serviceUsers). This issue tracks the same cleanup for pre-existing code, kept out of that PR to avoid unrelated churn.Known spots
internal/api/v1beta1connect/serviceuser.go—ListServiceUsers:var users []*frontierv1beta1.ServiceUserandfor _, user := range usersList(~lines 43-57)internal/api/v1beta1connect/project.go—var users []serviceuser.ServiceUserandvar transformedUsers []*frontierv1beta1.ServiceUser(~lines 249, 257)internal/store/postgres/serviceuser_repository.go—var transformedUsers []serviceuser.ServiceUser(~line 219)core/serviceuser/service.go—currentUserfor the service user inSudo/UnSudo(~lines 459-548)Worth a quick repo-wide sweep for more, e.g.:
Suggested naming
Follow the existing convention:
serviceUsersfor slices,serviceUser(orsuin short loops) for single values.Rename only — no behavior change.