Add missing parentheses

d0k · d0k · commit 93cb09642df3 · 2010-07-26T22:14:10.000+02:00
&amp; has higher precedence than ==, making this a noop. Use the less
error-prone S_IS* macros instead. Found by clang.
diff --git a/src/node_stdio.cc b/src/node_stdio.cc
@@ -163,9 +163,7 @@ static bool IsBlocking(int fd) {
     perror("fstat");
     return true;
   }
-  if (s.st_mode & S_IFSOCK == S_IFSOCK) return false;
-  if (s.st_mode & S_IFIFO == S_IFIFO) return false;
-  return true;
+  return !S_ISSOCK(s.st_mode) && !S_ISFIFO(s.st_mode);
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -163,9 +163,7 @@ static bool IsBlocking(int fd) {`
`163`	`163`	`perror("fstat");`
`164`	`164`	`return true;`
`165`	`165`	`}`
`166`		`- if (s.st_mode & S_IFSOCK == S_IFSOCK) return false;`
`167`		`- if (s.st_mode & S_IFIFO == S_IFIFO) return false;`
`168`		`- return true;`
	`166`	`+ return !S_ISSOCK(s.st_mode) && !S_ISFIFO(s.st_mode);`
`169`	`167`	`}`
`170`	`168`
`171`	`169`