Workflow using bad loop (temporalio#22)

mcbianconi · web-flow · commit d709acf2b3df · 2022-10-27T07:33:15.000-05:00
diff --git a/hello/hello_signal.py b/hello/hello_signal.py
@@ -16,7 +16,7 @@ def __init__(self) -> None:
     async def run(self) -> List[str]:
         # Continually handle from queue or wait for exit to be received
         greetings: List[str] = []
-        while not self._exit:
+        while True:
             # Wait for queue item or exit
             await workflow.wait_condition(
                 lambda: not self._pending_greetings.empty() or self._exit
@@ -26,7 +26,9 @@ async def run(self) -> List[str]:
             while not self._pending_greetings.empty():
                 greetings.append(f"Hello, {self._pending_greetings.get_nowait()}")
 
-        return greetings
+            # Exit if complete
+            if self._exit:
+                return greetings
 
     @workflow.signal
     async def submit_greeting(self, name: str) -> None:
