Use PyType_Ready() for initialization of the ob_type field of our

gvanrossum · gvanrossum · commit 62992af74ec8 · 2001-12-17T17:25:53.000Z
types (the tp_base field must be initialized prior to that call). git-svn-id: http://svn.python.org/projects/python/trunk@24787 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Modules/xxsubtype.c b/Modules/xxsubtype.c
@@ -242,11 +242,13 @@ initxxsubtype(void)
 
 	/* Fill in the deferred data addresses.  This must be done before
 	   PyType_Ready() is called. */
-	spamdict_type.ob_type = &PyType_Type;
 	spamdict_type.tp_base = &PyDict_Type;
+	if (PyType_Ready(&spamdict_type) < 0)
+		return;
 
-	spamlist_type.ob_type = &PyType_Type;
 	spamlist_type.tp_base = &PyList_Type;
+	if (PyType_Ready(&spamlist_type) < 0)
+		return;
 
 	m = Py_InitModule3("xxsubtype",
 			   xxsubtype_functions,
