Skip to content

Commit c729bf8

Browse files
author
j.s@google.com
committed
Fixed return type for FeedLinkFromString. Resolves issue 250.
1 parent c04c73a commit c729bf8

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

src/gdata/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -832,4 +832,4 @@ def __init__(self, count_hint=None, href=None, read_only=None, rel=None,
832832

833833

834834
def FeedLinkFromString(xml_string):
835-
return atom.CreateClassFromXMLString(EntryLink, xml_string)
835+
return atom.CreateClassFromXMLString(FeedLink, xml_string)

tests/gdata_test.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,5 +344,14 @@ def testGettersReturnCorrectTypes(self):
344344
self.assert_(isinstance(ep.GetXmlBlobString(), str))
345345

346346

347+
class FeedLinkTest(unittest.TestCase):
348+
349+
def testCorrectFromStringType(self):
350+
link = gdata.FeedLinkFromString(
351+
'<feedLink xmlns="http://schemas.google.com/g/2005" countHint="5"/>')
352+
self.assertTrue(isinstance(link, gdata.FeedLink))
353+
self.assertEqual(link.count_hint, '5')
354+
355+
347356
if __name__ == '__main__':
348357
unittest.main()

0 commit comments

Comments
 (0)