Add missing await in AioHttpIntegration. (getsentry#261)

janLo · untitaker · commit 085f47e731d7 · 2019-02-12T19:23:00.000+01:00
* Add missing await in AioHttpIntegration. The replaced _handle method of aiohttp.web.Application is a coroutine itself. So it has to await the call to the original handle otherwise its never awaited. This fixes getsentry#260 Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de> * Add testcase to demonstrate cashing aiohttp This demonstrates the behaviour in getsentry#260. Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
diff --git a/sentry_sdk/integrations/aiohttp.py b/sentry_sdk/integrations/aiohttp.py
@@ -32,7 +32,7 @@ async def sentry_app_handle(self, request, *args, **kwargs):
             async def inner():
                 hub = Hub.current
                 if hub.get_integration(AioHttpIntegration) is None:
-                    return old_handle(self, request, *args, **kwargs)
+                    return await old_handle(self, request, *args, **kwargs)
 
                 weak_request = weakref.ref(request)
 
diff --git a/tests/integrations/aiohttp/test_aiohttp.py b/tests/integrations/aiohttp/test_aiohttp.py
@@ -53,3 +53,22 @@ async def hello(request):
     assert resp.status == 403
 
     assert not events
+
+
+async def test_half_initialized(sentry_init, aiohttp_client, loop, capture_events):
+    sentry_init(integrations=[AioHttpIntegration()])
+    sentry_init()
+
+    async def hello(request):
+        return web.Response(text="hello")
+
+    app = web.Application()
+    app.router.add_get("/", hello)
+
+    events = capture_events()
+
+    client = await aiohttp_client(app)
+    resp = await client.get("/")
+    assert resp.status == 200
+
+    assert events == []
