Type conversion: 'long' as an alias for 'int'

pekkaklarck · pekkaklarck · commit e3c41f8a921f · 2018-11-20T16:04:39.000+02:00
diff --git a/atest/testdata/keywords/type_conversion/AnnotationsWithAliases.py b/atest/testdata/keywords/type_conversion/AnnotationsWithAliases.py
@@ -11,6 +11,10 @@ def int_(argument: 'INT', expected=None):
     _validate_type(argument, expected)
 
 
+def long_(argument: 'lOnG', expected=None):
+    _validate_type(argument, expected)
+
+
 def float_(argument: 'Float', expected=None):
     _validate_type(argument, expected)
 
diff --git a/atest/testdata/keywords/type_conversion/KeywordDecoratorWithAliases.py b/atest/testdata/keywords/type_conversion/KeywordDecoratorWithAliases.py
@@ -6,17 +6,22 @@
 from robot.utils import unicode
 
 
-@keyword(types=['Integer'])    # type is given as str
+@keyword(types=['Integer'])                # type always is given as str
 def integer(argument, expected=None):
     _validate_type(argument, expected)
 
 
-@keyword(types=[u'INT'])       # type is unicode on Python 2
+@keyword(types=[u'INT'])                   # type given as unicode on Python 2
 def int_(argument, expected=None):
     _validate_type(argument, expected)
 
 
-@keyword(types=['Float'])
+@keyword(types={'argument': 'lOnG'})       # type always given as str
+def long_(argument, expected=None):
+    _validate_type(argument, expected)
+
+
+@keyword(types={u'argument': u'Float'})    # type given as unicode on Python 2
 def float_(argument, expected=None):
     _validate_type(argument, expected)
 
diff --git a/atest/testdata/keywords/type_conversion/annotations_with_aliases.robot b/atest/testdata/keywords/type_conversion/annotations_with_aliases.robot
@@ -11,7 +11,7 @@ Force Tags               require-py3
 Integer
     Integer              42                        ${42}
     Int                  -1                        ${-1}
-    Integer              9999999999999999999999    ${9999999999999999999999}
+    Long                 9999999999999999999999    ${9999999999999999999999}
 
 Invalid integer
     [Template]           Conversion Should Fail
diff --git a/atest/testdata/keywords/type_conversion/keyword_decorator_with_aliases.robot b/atest/testdata/keywords/type_conversion/keyword_decorator_with_aliases.robot
@@ -10,7 +10,7 @@ Resource                 conversion.resource
 Integer
     Integer              42                        ${42}
     Int                  -1                        ${-1}
-    Integer              9999999999999999999999    ${9999999999999999999999}
+    Long                 9999999999999999999999    ${9999999999999999999999}
 
 Invalid integer
     [Template]           Conversion Should Fail
diff --git a/doc/userguide/src/ExtendingRobotFramework/CreatingTestLibraries.rst b/doc/userguide/src/ExtendingRobotFramework/CreatingTestLibraries.rst
@@ -1153,8 +1153,8 @@ case-insensitive.
    |             |               |            | to handle them specially if needed. All comparisons are        |                                      |
    |             |               |            | case-insensitive.                                              |                                      |
    +-------------+---------------+------------+----------------------------------------------------------------+--------------------------------------+
-   | int_        | Integral_     | integer    | Conversion is done using the int_ built-in function.           | | `42`                               |
-   |             |               |            | If that fails and type is got implicitly from default values,  | | `3.14` (only with implicit type)   |
+   | int_        | Integral_     | integer,   | Conversion is done using the int_ built-in function.           | | `42`                               |
+   |             |               | long       | If that fails and type is got implicitly from default values,  | | `3.14` (only with implicit type)   |
    |             |               |            | also float_ conversion is attempted.                           |                                      |
    +-------------+---------------+------------+----------------------------------------------------------------+--------------------------------------+
    | float_      | Real_         | double     | Conversion is done using the float_ built-in.                  | | `3.14`                             |
diff --git a/src/robot/running/arguments/typeconverters.py b/src/robot/running/arguments/typeconverters.py
@@ -142,7 +142,7 @@ class IntegerConverter(TypeConverter):
     type = int
     abc = Integral
     type_name = 'integer'
-    aliases = ('int',)
+    aliases = ('int', 'long')
 
     def _convert(self, value, explicit_type=True):
         try:
