enhance/fix parsing syslog messages

yanne · yanne · commit b742bf0d965e · 2019-09-03T07:27:34.000+03:00
diff --git a/atest/robot/parsing/caching_libs_and_resources.robot b/atest/robot/parsing/caching_libs_and_resources.robot
@@ -4,8 +4,9 @@ Resource          atest_resource.robot
 *** Test Cases ***
 Import Libraries Only Once
     [Setup]    Run Tests And Set $SYSLOG    parsing/library_caching
-    : FOR    ${name}    IN    Test 1.1    Test 1.2    Test 2.1    Test 2.2
-    \    Check Test Case    ${name}
+    FOR    ${name}    IN    Test 1.1    Test 1.2    Test 2.1    Test 2.2
+        Check Test Case    ${name}
+    END
     Should Contain X Times    ${SYSLOG}    Imported library 'BuiltIn' with arguments [ ]    1
     Should Contain X Times    ${SYSLOG}    Found test library 'BuiltIn' with arguments [ ] from cache    2
     Should Contain X Times    ${SYSLOG}    Imported library 'OperatingSystem' with arguments [ ]    1
@@ -28,9 +29,10 @@ Process Resource Files Only Once
     Check Log Message    ${tc.kws[0].kws[2].kws[0].msgs[0]}    variable value from 02 resource
     Check Log Message    ${tc.kws[1].msgs[0]}    variable value from 03 resource
     ${dir} =    Normalize Path    ${DATADIR}/parsing/resource_parsing
-    # These messages come twice. Once when they are parsed as test case files and a second time when parsed as resource files.
-    Should Contain X Times    ${SYSLOG}    Parsing file '${dir}${/}02_resource.robot'    2
-    Should Contain X Times    ${SYSLOG}    Parsing file '${dir}${/}03_resource.robot'    2
+    Should Contain X Times    ${SYSLOG}    Parsing file '${dir}${/}02_resource.robot'             1
+    Should Contain X Times    ${SYSLOG}    Parsing resource file '${dir}${/}02_resource.robot'    1
+    Should Contain X Times    ${SYSLOG}    Parsing file '${dir}${/}03_resource.robot'             1
+    Should Contain X Times    ${SYSLOG}    Parsing resource file '${dir}${/}03_resource.robot'    1
     # Check that resources were parsed only once
     Syslog File Should Contain In Order    Parsing directory '${dir}'.
     Syslog File Should Contain In Order    Parsing file '${dir}${/}01_tests.robot'.
diff --git a/src/robot/running/builder/builders.py b/src/robot/running/builder/builders.py
@@ -51,6 +51,7 @@ def build(self, *paths):
 class ResourceFileBuilder(object):
 
     def build(self, path):
+        LOGGER.info("Parsing resource file '%s'." % path)
         data = get_resource_file_ast(path)
         return build_resource(data, path)
 
@@ -123,6 +124,8 @@ def build_suite(source, datapath=None, parent_defaults=None):
         #print(ast.dump(ast))
         SettingsBuilder(suite, defaults).visit(ast)
         SuiteBuilder(suite, defaults).visit(ast)
+        if not suite.tests:
+            LOGGER.info("Data source '%s' has no tests or tasks." % datapath)
         suite.rpa = _get_rpa_mode(ast)
     return suite, defaults
 
@@ -141,6 +144,8 @@ def build_resource(data, source):
     resource = ResourceFile(source=source)
     if data.sections:
         ResourceBuilder(resource).visit(data)
+        LOGGER.info("Imported resource file '%s' (%d keywords)."
+                    % (source, len(resource.keywords)))
     else:
         LOGGER.warn("Imported resource file '%s' is empty." % source)
     return resource
